You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "SoberChina (via GitHub)" <gi...@apache.org> on 2023/04/14 04:41:49 UTC

[GitHub] [incubator-streampark] SoberChina opened a new pull request, #2623: [Improve] Translate comments into English for FlinkAppState.java

SoberChina opened a new pull request, #2623:
URL: https://github.com/apache/incubator-streampark/pull/2623

   <!--
   Thank you for contributing to StreamPark! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   ## Contribution Checklist
   
     - If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
   
     - Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
   
   -->
   
   ## What changes were proposed in this pull request
   
   Issue Number: close #2621
   
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   
   
   
   <!--*(example:)*
   - *Added integration tests for end-to-end.*
   - *Added *Test to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys merged pull request #2623: [Improve] Translate comments into English for FlinkAppState.java

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2623:
URL: https://github.com/apache/incubator-streampark/pull/2623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] SoberChina commented on a diff in pull request #2623: [Improve] Translate comments into English for FlinkAppState.java

Posted by "SoberChina (via GitHub)" <gi...@apache.org>.
SoberChina commented on code in PR #2623:
URL: https://github.com/apache/incubator-streampark/pull/2623#discussion_r1166355288


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/enums/FlinkAppState.java:
##########


Review Comment:
   Yes, the comments should be in one sentence, and handwritten letters should be capitalized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] RocMarshal commented on a diff in pull request #2623: [Improve] Translate comments into English for FlinkAppState.java

Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #2623:
URL: https://github.com/apache/incubator-streampark/pull/2623#discussion_r1166284435


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/enums/FlinkAppState.java:
##########
@@ -68,13 +68,13 @@ public enum FlinkAppState implements Serializable {
   SUSPENDED(11),
   /** The job is currently reconciling and waits for task execution report to recover state. */
   RECONCILING(12),
-  /** 失联 */
+  /** Loss of mapping */
   LOST(13),
 
-  /** 射影中... */
+  /** Mapping */
   MAPPING(14),
 
-  /** 其他不关心的状态... */
+  /** Other statuses */
   OTHER(15),
 
   /** has rollback */

Review Comment:
   ```suggestion
     /** Has rollback */
   ```



##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/enums/FlinkAppState.java:
##########


Review Comment:
   `added new job to database` -> `Added new job to database` 
   `job SUCCEEDED on yarn`->`Job SUCCEEDED on yarn`
   `has killed in Yarn` -> `Has killed in Yarn`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] SoberChina commented on a diff in pull request #2623: [Improve] Translate comments into English for FlinkAppState.java

Posted by "SoberChina (via GitHub)" <gi...@apache.org>.
SoberChina commented on code in PR #2623:
URL: https://github.com/apache/incubator-streampark/pull/2623#discussion_r1166355288


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/enums/FlinkAppState.java:
##########


Review Comment:
   @RocMarshal  Thank you very much for your reminder.Yes, the comments should be in one sentence, and handwritten letters should be capitalized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org