You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/26 21:43:53 UTC
[GitHub] [druid] xvrl opened a new pull request #9570: fix nullhandling
exceptions related to test ordering
xvrl opened a new pull request #9570: fix nullhandling exceptions related to test ordering
URL: https://github.com/apache/druid/pull/9570
Tests might get executed in different order depending on the maven version and the test environment. This may lead to `NullHandling module not initialized` errors for some tests where we do not initialize
null-handling explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9570: fix nullhandling
exceptions related to test ordering
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9570: fix nullhandling exceptions related to test ordering
URL: https://github.com/apache/druid/pull/9570#issuecomment-605106786
@xvrl we usually backport only fixes for security bugs or regressions to a release branch, but I think this PR seems a kind of bug and easy to backport. Would you mind backporting it into 0.18.0 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #9570: fix
nullhandling exceptions related to test ordering
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering
URL: https://github.com/apache/druid/pull/9570#discussion_r398916305
##########
File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourceTest.java
##########
@@ -66,6 +67,10 @@
@RunWith(Enclosed.class)
public class HdfsInputSourceTest
{
+ static {
+ NullHandling.initializeForTests();
Review comment:
Thanks. I think they were added before we add `InitializeNullHandlingTest`. We could clean them up someday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl commented on a change in pull request #9570: fix
nullhandling exceptions related to test ordering
Posted by GitBox <gi...@apache.org>.
xvrl commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering
URL: https://github.com/apache/druid/pull/9570#discussion_r398967538
##########
File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourceTest.java
##########
@@ -66,6 +67,10 @@
@RunWith(Enclosed.class)
public class HdfsInputSourceTest
{
+ static {
+ NullHandling.initializeForTests();
Review comment:
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #9570: fix
nullhandling exceptions related to test ordering
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering
URL: https://github.com/apache/druid/pull/9570#discussion_r398912755
##########
File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourceTest.java
##########
@@ -66,6 +67,10 @@
@RunWith(Enclosed.class)
public class HdfsInputSourceTest
{
+ static {
+ NullHandling.initializeForTests();
Review comment:
nit: you can extend `InitializedNullHandlingTest` instead of adding a static block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9570: fix nullhandling
exceptions related to test ordering
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9570: fix nullhandling exceptions related to test ordering
URL: https://github.com/apache/druid/pull/9570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] xvrl commented on a change in pull request #9570: fix
nullhandling exceptions related to test ordering
Posted by GitBox <gi...@apache.org>.
xvrl commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering
URL: https://github.com/apache/druid/pull/9570#discussion_r398915581
##########
File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourceTest.java
##########
@@ -66,6 +67,10 @@
@RunWith(Enclosed.class)
public class HdfsInputSourceTest
{
+ static {
+ NullHandling.initializeForTests();
Review comment:
sure, I can do that, I merely copied this from other existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org