You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/02/11 11:48:04 UTC

[GitHub] flink pull request: [FLINK-3369] [runtime] Make RemoteTransportExc...

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/1621

    [FLINK-3369] [runtime] Make RemoteTransportException instance of CancelTaskException

    Problem: RemoteTransportException (RTE) is thrown on data transfer failures when the remote data producer fails. Because RTE is an instance of IOException, it can happen that the RTE is reported as the root job failure cause.
    
    Solution: Make RTE instance of CancelTaskException, leading to cancellation of the task and not failure.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 3369-transport

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1621
    
----
commit 14ade91827b5fe3e01e4bef29bbd9aa41c573776
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-02-10T18:51:20Z

    [FLINK-3369] [runtime] Make RemoteTransportException instance of CancelTaskException
    
    Problem: RemoteTransportException (RTE) is thrown on data transfer failures
    when the remote data producer fails. Because RTE is an instance of IOException,
    it can happen that the RTE is reported as the root job failure cause.
    
    Solution: Make RTE instance of CancelTaskException, leading to cancellation of
    the task and not failure.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3369] [runtime] Make RemoteTransportExc...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1621#issuecomment-182813990
  
    Do the exceptions still have information about which connection failed? I see that the network address parameter is removed from the exceptions and also not included in the message.
    
    Otherwise, looks pretty straightforward and good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3369] [runtime] Make RemoteTransportExc...

Posted by uce <gi...@git.apache.org>.

Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1621#issuecomment-182825136
  
    Thanks for looking into it. The remote address is actually part of all the messages, but I've readded it as an explicit argument. For the local variant, the address is known at the job manager. I will go ahead and merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3369] [runtime] Make RemoteTransportExc...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---