You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 02:37:35 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #701:
testbuild.sh: Make the use of "git clean" optional
yamt opened a new pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #701:
testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402708969
##########
File path: tools/README.txt
##########
@@ -994,18 +994,24 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-si|-sl>] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
Review comment:
will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request
#701: testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402942757
##########
File path: tools/README.txt
##########
@@ -994,18 +994,26 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] [-p] [-G] <testlist-file>
./testbuild.sh -h
Where:
-l|m|c|u|g|n selects Linux (l), macOS (m), Cygwin (c),
- Ubuntu under Windows 10 (u), or Windows native (n). Default Linux
- -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
- -t <topdir> provides the absolute path to top nuttx/ directory. Default $PWD/../nuttx
- -p only print the list of configs without running any builds
- -j <ncpus> passed on to make. Default: No -j make option
+ Ubuntu under Windows 10 (u), MSYS/MSYS2 (g) or Windows native (n). Default Linux
-d enables script debug output
-x exit on build failures
+ -j <ncpus> passed on to make. Default: No -j make option.
+ -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
+ -t <topdir> provides the absolute path to top nuttx/ directory.
+ Default $WD/../nuttx, where $WD is the parent directory of
+ the directory where this script is.
+ -p only print the list of configs without running any builds
+ -G Use "git clean -xfdq" instead of "make distclean" to clean the tree.
Review comment:
@xiaoxiang781216 I have been burned by this sort of thing, killing dev tool artifacts. Should this warn a user on a non CI platform?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #701: testbuild.sh:
Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#issuecomment-608209004
@yamt I just restarted the build looks like it got past whatever that error was.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #701:
testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#issuecomment-608203097
LGTM, @hartmannathan @btashton if you don't have any concern, I will merge it after the github pass the build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #701:
testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402708995
##########
File path: tools/README.txt
##########
@@ -994,18 +994,24 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-si|-sl>] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
./testbuild.sh -h
Where:
-l|m|c|u|g|n selects Linux (l), macOS (m), Cygwin (c),
- Ubuntu under Windows 10 (u), or Windows native (n). Default Linux
- -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
- -t <topdir> provides the absolute path to top nuttx/ directory. Default $PWD/../nuttx
- -p only print the list of configs without running any builds
- -j <ncpus> passed on to make. Default: No -j make option
+ Ubuntu under Windows 10 (u), MSYS/MSYS2 (g) or Windows native (n). Default Linux
-d enables script debug output
-x exit on build failures
+ -j <ncpus> passed on to make. Default: No -j make option.
+ -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
+ -t <topdir> provides the absolute path to top nuttx/ directory. Default /Users/yamamoto/git/nuttx/nuttx/tools/../nuttx
Review comment:
oops
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #701: testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402704527
##########
File path: tools/README.txt
##########
@@ -994,18 +994,24 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-si|-sl>] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
Review comment:
Revert the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #701: testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402704527
##########
File path: tools/README.txt
##########
@@ -994,18 +994,24 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-si|-sl>] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
Review comment:
[-si|-sl] has been moved into testlist-file, let's remove the wrong description from testbuild.sh instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #701: testbuild.sh: Make
the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#issuecomment-608205681
the failure doesn't seem related to the change. what's the proper way to re-run the ci?
> /usr/bin/docker: error pulling image configuration: received unexpected HTTP status: 504 Gateway Time-out.
> See '/usr/bin/docker run --help'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #701: testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402705112
##########
File path: tools/README.txt
##########
@@ -994,18 +994,24 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-si|-sl>] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
./testbuild.sh -h
Where:
-l|m|c|u|g|n selects Linux (l), macOS (m), Cygwin (c),
- Ubuntu under Windows 10 (u), or Windows native (n). Default Linux
- -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
- -t <topdir> provides the absolute path to top nuttx/ directory. Default $PWD/../nuttx
- -p only print the list of configs without running any builds
- -j <ncpus> passed on to make. Default: No -j make option
+ Ubuntu under Windows 10 (u), MSYS/MSYS2 (g) or Windows native (n). Default Linux
-d enables script debug output
-x exit on build failures
+ -j <ncpus> passed on to make. Default: No -j make option.
+ -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
+ -t <topdir> provides the absolute path to top nuttx/ directory. Default /Users/yamamoto/git/nuttx/nuttx/tools/../nuttx
Review comment:
Reword /Users/yamamoto/git/nuttx/nuttx/tools/../nuttx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #701: testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402950219
##########
File path: tools/README.txt
##########
@@ -994,18 +994,26 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] [-p] [-G] <testlist-file>
./testbuild.sh -h
Where:
-l|m|c|u|g|n selects Linux (l), macOS (m), Cygwin (c),
- Ubuntu under Windows 10 (u), or Windows native (n). Default Linux
- -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
- -t <topdir> provides the absolute path to top nuttx/ directory. Default $PWD/../nuttx
- -p only print the list of configs without running any builds
- -j <ncpus> passed on to make. Default: No -j make option
+ Ubuntu under Windows 10 (u), MSYS/MSYS2 (g) or Windows native (n). Default Linux
-d enables script debug output
-x exit on build failures
+ -j <ncpus> passed on to make. Default: No -j make option.
+ -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
+ -t <topdir> provides the absolute path to top nuttx/ directory.
+ Default $WD/../nuttx, where $WD is the parent directory of
+ the directory where this script is.
+ -p only print the list of configs without running any builds
+ -G Use "git clean -xfdq" instead of "make distclean" to clean the tree.
Review comment:
By default we sue make distclean. if user add -G option, she/he should know the side effect. The help also indicate this:
```
-G Use "git clean -xfdq" instead of "make distclean" to clean the tree.
This option may speed up the builds. However, note that:
* This assumes that your trees are git based.
* This assumes that only nuttx and apps repos need to be cleaned.
* If the tree has files not managed by git, they will be removed
as well.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #701:
testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] hartmannathan commented on issue #701:
testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#issuecomment-608204990
> LGTM, @hartmannathan @btashton if you don't have any concern, I will merge it after the github pass the build.
I don't have any concerns. LGTM, I like the new command line option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #701: testbuild.sh: Make the use of "git clean" optional
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #701: testbuild.sh: Make the use of "git clean" optional
URL: https://github.com/apache/incubator-nuttx/pull/701#discussion_r402950219
##########
File path: tools/README.txt
##########
@@ -994,18 +994,26 @@ testbuild.sh
$ ./testbuild.sh -h
- USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] <testlist-file>
+ USAGE: ./testbuild.sh [-l|m|c|u|g|n] [-d] [-x] [-j <ncpus>] [-a <appsdir>] [-t <topdir>] [-p] [-G] <testlist-file>
./testbuild.sh -h
Where:
-l|m|c|u|g|n selects Linux (l), macOS (m), Cygwin (c),
- Ubuntu under Windows 10 (u), or Windows native (n). Default Linux
- -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
- -t <topdir> provides the absolute path to top nuttx/ directory. Default $PWD/../nuttx
- -p only print the list of configs without running any builds
- -j <ncpus> passed on to make. Default: No -j make option
+ Ubuntu under Windows 10 (u), MSYS/MSYS2 (g) or Windows native (n). Default Linux
-d enables script debug output
-x exit on build failures
+ -j <ncpus> passed on to make. Default: No -j make option.
+ -a <appsdir> provides the relative path to the apps/ directory. Default ../apps
+ -t <topdir> provides the absolute path to top nuttx/ directory.
+ Default $WD/../nuttx, where $WD is the parent directory of
+ the directory where this script is.
+ -p only print the list of configs without running any builds
+ -G Use "git clean -xfdq" instead of "make distclean" to clean the tree.
Review comment:
By default we use make distclean. if user add -G option, she/he should know the side effect. The help also indicate this:
```
-G Use "git clean -xfdq" instead of "make distclean" to clean the tree.
This option may speed up the builds. However, note that:
* This assumes that your trees are git based.
* This assumes that only nuttx and apps repos need to be cleaned.
* If the tree has files not managed by git, they will be removed
as well.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services