[GitHub] [pinot] walterddr commented on a diff in pull request #10870: [multistage] register opChain finish callback for pipeline breaker to continue

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10870:
URL: https://github.com/apache/pinot/pull/10870#discussion_r1222195019


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/RoundRobinScheduler.java:
##########
@@ -169,6 +169,8 @@ public void deregister(OpChain operatorChain) {
     } finally {
       _lock.unlock();
     }
+    // invoke opChain deregister callback
+    operatorChain.getOpChainFinishCallback().accept(operatorChain.getId());

Review Comment:
   I dont actually like this way of doing things. 
   `opChain.finish` call back should be automatically called when deregistered. however this rely on a very specific impl of the Scheduler.deregister. 
   
   let's refactor this later as both the onDataAvai and onFinish callback seems a bit weird.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org