[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3945: fix #3929 support range sharding to broadcast sql to all actual tables

[GitBox <gi...@apache.org>]

terrymanu edited a comment on issue #3945: fix #3929 support range sharding to broadcast sql to all actual tables
URL: https://github.com/apache/incubator-shardingsphere/pull/3945#issuecomment-573419900
 
 
   We need to discuss this pull request:
   1. For standard sharding strategy, user need config precise algorithm (for =, IN) and range algorithm (for BETWEEN AND, <, >,  >=, <=). If user do not config range algorithm, the BETWEEN should query all data nodes, that correct;
   2. For inline sharding strategy, user only can config precise algorithm via inline expression, and cannot config range algorithm. So throw exception when SQL contains BETWEEN may better than query all data nodes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services