You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/17 20:24:11 UTC

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6926: Clean up generated files for recommendation engine in case of failure

jackjlli commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633844984



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimator.java
##########
@@ -430,44 +422,48 @@ private long calculateMemoryForCompletedSegmentsPerPartition(long completedSegme
     return _numSegmentsQueriedPerHost;
   }
 
+  public void cleanup() {

Review comment:
       Could we make this class auto-closable, so that we don't have to worry about where it needs to be called?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org