You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "f2par0 (via GitHub)" <gi...@apache.org> on 2024/12/02 13:06:26 UTC
[PR] update destroy method to be compatible with spring 6 [aries]
f2par0 opened a new pull request, #299:
URL: https://github.com/apache/aries/pull/299
Problem found : the class `SpringApplicationContext` inherits from `org.springframework.context.support.AbstractApplicationContext` , which had a `destroy` method in version 4, but was deprecated then removed in the version 6 of spring framework.
The name of the destroy method must be updated to match this new name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "amergey (via GitHub)" <gi...@apache.org>.
amergey commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1903342717
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
Yes, but people using spring cannot stay with Java 8, so blueprint-spring itself will not be use in java 8.
Anyway I realized looking at this PR than same code can work for spring 5 and current spring 6 as well with no differences yet, so no need to separate artifacts yet, and blueprint-spring can stay with java 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1920658434
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
Hi @f2par0
please rebase your branch and update the spring version also in `blueprint-spring-extender` and `blueprint-itests` to the highest 5.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1866432637
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
I checked that spring 6.x does not work with minimal java 8 that we should have in the repo
you can find the errors by running:
```
mvn -f blueprint/blueprint-spring clean package
```
or checking your branch with definition of blueprint build from https://github.com/apache/aries/pull/297
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -191,6 +191,13 @@
<build>
<plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <target>1.7</target>
Review Comment:
java 8 should be minimal supported version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update destroy method to be compatible with spring 6 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on PR #299:
URL: https://github.com/apache/aries/pull/299#issuecomment-2511674971
Hi @f2par0
could you create an [jira issue](https://issues.apache.org/jira/projects/ARIES/issues) and add jira id to the PR name and commit?
The blueprint-spring subproject has a dependency to spring - could you also check them? I think they should be updated to version 6.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "amergey (via GitHub)" <gi...@apache.org>.
amergey commented on PR #299:
URL: https://github.com/apache/aries/pull/299#issuecomment-2571704789
You may have a look to an old PR I opened for spring 5 (which I quickly updated for spring 6)
https://github.com/apache/aries/pull/300/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] Update destroy method to be compatible with spring 5 and 6 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on PR #299:
URL: https://github.com/apache/aries/pull/299#issuecomment-2616539744
Thank you @f2par0 for the contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] Update destroy method to be compatible with spring 5 and 6 [aries]
Posted by "f2par0 (via GitHub)" <gi...@apache.org>.
f2par0 commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1930353929
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
Hello, @alien11689
Rebase is done, I have a test error in Apache Aries Blueprint Sample, but I'm not sure if and how I can fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "amergey (via GitHub)" <gi...@apache.org>.
amergey commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1903315992
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
spring 5 is end of life, it does not really make sense to support spring 5. blueprint-spring should support spring 6 (therefore need to move to jdk17) is there a way to move one project without moving all blueprint projects ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1903328157
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
There are a lot of possible users who stay with Java 8 so it's better to keep all the artifacts compatible with Java 8 if possible. Especially that Spring is not often used in OSGi projects.
But personally I see the value in using the newest version of Spring.
Maybe the solution here may be creating the new artifact `blueprint-spring6`. Existing `blueprint-spring` could use newest spring 5.x version supporting Java 8. Perfectly the code should be reused between modules so the new module should only override necessary parts (if possible).
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "amergey (via GitHub)" <gi...@apache.org>.
amergey commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1903342717
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
Yes, but people using spring cannot stay with Java 8, so blueprint-spring itself will not be use in java 8. Anyway
I realized looking at this PR than same code can work for spring 5 and current spring 6 as well with no differences yet, so no need to separate artifacts yet, and blueprint-spring can stay with java 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] update destroy method to be compatible with spring 6 [aries]
Posted by "f2par0 (via GitHub)" <gi...@apache.org>.
f2par0 commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1866722640
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
yes, spring 6 is for java 17, so if java 8 support is required, the latest version is 5.3.39.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] Update destroy method to be compatible with spring 5 and 6 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 commented on code in PR #299:
URL: https://github.com/apache/aries/pull/299#discussion_r1930980707
##########
blueprint/blueprint-spring/pom.xml:
##########
@@ -119,13 +119,13 @@
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
- <version>4.2.2.RELEASE</version>
+ <version>6.1.15</version>
Review Comment:
I run blueprint workflow and it's green. `samples` modules does not work correctly on trunk so it's not blocking the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ARIES-2161] Update destroy method to be compatible with spring 5 and 6 [aries]
Posted by "alien11689 (via GitHub)" <gi...@apache.org>.
alien11689 merged PR #299:
URL: https://github.com/apache/aries/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@aries.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org