You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/12/05 21:25:12 UTC

[jira] [Commented] (LUCENE-6055) PayloadAttribute.clone() should deep clone its BytesRef

    [ https://issues.apache.org/jira/browse/LUCENE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236049#comment-14236049 ] 

ASF subversion and git services commented on LUCENE-6055:
---------------------------------------------------------

Commit 1643417 from [~mikemccand] in branch 'dev/branches/lucene_solr_4_10'
[ https://svn.apache.org/r1643417 ]

LUCENE-6055: PayloadAttribute.clone() should deep clone its BytesRef

> PayloadAttribute.clone() should deep clone its BytesRef
> -------------------------------------------------------
>
>                 Key: LUCENE-6055
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6055
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 4.10.3, Trunk, 5.x
>
>         Attachments: LUCENE-6055.patch, LUCENE-6055.patch
>
>
> PayloadAttribute.clone() does a shallow clone, unlike e.g. CharTermAttribute. Attributes should deep clone, otherwise capturing state isn't correct. In addition, both PA's and CTA's .clone() falsely documents that they do shallow cloning on purposes, so need to fix that too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org