You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by dongeforever <gi...@git.apache.org> on 2017/02/08 03:02:58 UTC
[GitHub] incubator-rocketmq pull request #54: [ROCKETMQ-83] Fix quick start, annotate...
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/54
[ROCKETMQ-83] Fix quick start, annotate setNamesrvAddr
Fix quick start, annotate setNamesrvAddr
@zhouxinyu please have a review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongeforever/incubator-rocketmq ROCKETMQ-83
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit b72024c4a151245b21d11539aea41c52e7397491
Author: dongeforever <zh...@yeah.net>
Date: 2017-02-08T03:01:25Z
[ROCKETMQ-83] Fix quick start, annotate setNamesrvAddr
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
[](https://coveralls.io/builds/10049068)
Coverage increased (+0.2%) to 31.488% when pulling **b271e30a2da3e0972f95d6c3b29e05f89584a71c on dongeforever:ROCKETMQ-83** into **e6aaedcf4d23f95791c51fb510baf369c8b1f5c1 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Yes, both quickstart.Consumer and quickstart.Producer should have xxx.setNamesrv("XXX") as part of documentation, showing how to set name server list programmatically. My fault to leave them as code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
[](https://coveralls.io/builds/10049158)
Coverage decreased (-0.005%) to 31.311% when pulling **b271e30a2da3e0972f95d6c3b29e05f89584a71c on dongeforever:ROCKETMQ-83** into **e6aaedcf4d23f95791c51fb510baf369c8b1f5c1 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
How about make a new PR for https://issues.apache.org/jira/browse/ROCKETMQ-84 and update this one? Becuase title is for ROCKETMQ-83, somebody would be confused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Hi, `quickStart.Consumer` also has the same issue, could you please fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
[](https://coveralls.io/builds/10049054)
Coverage increased (+0.3%) to 31.586% when pulling **b271e30a2da3e0972f95d6c3b29e05f89584a71c on dongeforever:ROCKETMQ-83** into **e6aaedcf4d23f95791c51fb510baf369c8b1f5c1 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #54: [ROCKETMQ-83] Fix quick start, annotate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
@lizhanhui This problem let me feel a bit awkward when we double-check the 4.0.0 vote checklist. May be, we need to let example module into integration test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
@zhouxinyu Consumer is also ok now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
@vongosling I have created a new JIRA issue for it: https://issues.apache.org/jira/browse/ROCKETMQ-84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Could you relocate the line properly and wrap the code using appropriate javadoc, say {@code Code is here;} http://stackoverflow.com/questions/541920/multiple-line-code-example-in-javadoc-comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
It works fine. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
BTW, should we remove example.transaction.* as this feature is not fully implemented in current release. It does not make sense having orphan examples alone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #54: [ROCKETMQ-83] Fix quick start, annotate setNam...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/54
Agree. All directly executable code should be part of the e2e tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---