You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "J-HowHuang (via GitHub)" <gi...@apache.org> on 2026/06/02 20:43:07 UTC
[PR] Exclude embedded Jetty from Hadoop deps in pinot-orc/pinot-parquet (CVE-2026-2332) [pinot]
J-HowHuang opened a new pull request, #18659:
URL: https://github.com/apache/pinot/pull/18659
## Problem
`hadoop-common` (and `hadoop-hdfs`) pull `org.eclipse.jetty` transitives (`jetty-server` -> `jetty-http`, plus `jetty-util`/`servlet`/`webapp`) for Hadoop's embedded `HttpServer2` web UI. `pinot-orc` and `pinot-parquet` only use `org.apache.hadoop.fs.Path` and `org.apache.hadoop.conf.Configuration` to read data — they never start an `HttpServer2` — so the Jetty jars only leak into runtime distributions and surface **CVE-2026-2332** (jetty-http request smuggling, `jetty-http <= 9.4.59`) on any image that bundles these plugins.
Additionally, `hadoop-client-runtime` is a Hadoop uber-jar that bundles its own copy of Jetty (relocated to `org.apache.hadoop.shaded.org.eclipse.jetty`). A Maven `<exclusion>` cannot remove those classes since they are baked into the uber-jar rather than resolved as a dependency node, and the leftover `jetty-*` Maven metadata inside it still makes scanners flag CVE-2026-2332 in the `pinot-parquet` shaded jar.
## Changes
1. **Exclude `org.eclipse.jetty` from `hadoop-common` and `hadoop-hdfs`** in both `pinot-orc` and `pinot-parquet`.
2. **Scope `hadoop-mapreduce-client-core` to `test` in `pinot-parquet`** (documented "Used for Parquet Writer in tests"), removing its compile-scope `hadoop-yarn-client -> websocket-client -> jetty-client -> jetty-http` chain.
3. **Add a shade-plugin filter in `pinot-parquet`** (`combine.children="append"`, preserving the inherited root-pom filters) that strips the relocated Jetty classes, their Maven metadata, and the orphaned `ServiceLoader` entries from the shaded jar.
## Verification
- `dependency:tree` shows no compile/runtime-scope Jetty remains in either module while `hadoop-common`/`hadoop-hdfs` themselves still resolve.
- The rebuilt `pinot-parquet` shaded jar contains zero `org.eclipse.jetty` entries while the shaded Woodstox classes (needed by Hadoop `Configuration`) remain.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Exclude embedded Jetty from Hadoop deps in pinot-orc/pinot-parquet (CVE-2026-2332) [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #18659:
URL: https://github.com/apache/pinot/pull/18659#issuecomment-4610282383
what about hadoop-client-runtime and hadoop-common dependencies ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Exclude embedded Jetty from Hadoop deps in pinot-orc/pinot-parquet (CVE-2026-2332) [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya merged PR #18659:
URL: https://github.com/apache/pinot/pull/18659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Exclude embedded Jetty from Hadoop deps in pinot-orc/pinot-parquet (CVE-2026-2332) [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18659:
URL: https://github.com/apache/pinot/pull/18659#issuecomment-4607280658
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18659?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.80%. Comparing base ([`cfc8063`](https://app.codecov.io/gh/apache/pinot/commit/cfc8063d9e198bed73fa885f99767bd5b41ead51?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ea9cdf8`](https://app.codecov.io/gh/apache/pinot/commit/ea9cdf837ba0a232c9874db5cb9f21017b4593e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (cfc8063) and HEAD (ea9cdf8). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (cfc8063) | HEAD (ea9cdf8) |
>|------|------|------|
>|java-21|5|1|
>|unittests|2|1|
>|temurin|5|1|
>|unittests2|1|0|
>|integration|3|0|
>|integration1|1|0|
>|integration2|1|0|
>|custom-integration1|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18659 +/- ##
============================================
- Coverage 64.45% 56.80% -7.65%
+ Complexity 1291 1 -1290
============================================
Files 3365 2577 -788
Lines 208066 149645 -58421
Branches 32482 24180 -8302
============================================
- Hits 134108 85011 -49097
+ Misses 63171 57443 -5728
+ Partials 10787 7191 -3596
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.80% <ø> (-7.65%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.80% <ø> (-7.65%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.80% <ø> (-7.65%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.80% <ø> (-0.02%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18659?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Exclude embedded Jetty from Hadoop deps in pinot-orc/pinot-parquet (CVE-2026-2332) [pinot]
Posted by "J-HowHuang (via GitHub)" <gi...@apache.org>.
J-HowHuang commented on PR #18659:
URL: https://github.com/apache/pinot/pull/18659#issuecomment-4617181025
@xiangfu0 @yashmayya moved the exclusion of jetty and the filter of maven-shade-plugin to the root pom.xml, as this exclusion makes more sense to be global instead of individual modules, and the fact that we already have some exclusions and the use of maven-shade-plugin filters on some modules there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Exclude embedded Jetty from Hadoop deps in pinot-orc/pinot-parquet (CVE-2026-2332) [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #18659:
URL: https://github.com/apache/pinot/pull/18659#issuecomment-4617316950
Thanks, I think this is a cleaner approach, merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org