You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2024/01/14 15:27:46 UTC

[PR] Revert "[hive] Improve hive database is exists yet create/drop database (#2595)" [incubator-paimon]

Zouxxyy opened a new pull request, #2693:
URL: https://github.com/apache/incubator-paimon/pull/2693

   
   
   This reverts commit b3fd931e0c24202e605489cfcd085314a0b0c470.
   
   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "[hive] Improve hive database is exists yet create/drop database (#2595)" [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #2693:
URL: https://github.com/apache/incubator-paimon/pull/2693#issuecomment-1891236223

   Hi @Zouxxyy , can you explain more about why we need to revert this commit? test error? performance?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "[hive] Improve hive database is exists yet create/drop database (#2595)" [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2693:
URL: https://github.com/apache/incubator-paimon/pull/2693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "[hive] Improve hive database is exists yet create/drop database (#2595)" [incubator-paimon]

Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #2693:
URL: https://github.com/apache/incubator-paimon/pull/2693#issuecomment-1891246871

   > Hi @Zouxxyy , can you explain more about why we need to revert this commit? test error? performance?
   
   Check alreadly in `createDatabase`, such as whether it is a system db or whether the db exists. `CreateDatabaseImpl` does not require additional verification.
   
   ```java
       public void createDatabase(String name, boolean ignoreIfExists)
               throws DatabaseAlreadyExistException {
           if (isSystemDatabase(name)) {
               throw new ProcessSystemDatabaseException();
           }
           if (databaseExists(name)) {
               if (ignoreIfExists) {
                   return;
               }
               throw new DatabaseAlreadyExistException(name);
           }
   
           createDatabaseImpl(name);
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org