You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Donal Lafferty <do...@citrix.com> on 2013/08/07 15:49:44 UTC
Review Request 13376: Fix QuickCloud secondary storage service
ListTemplateCommand and ListVolumeCommand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13376/
-----------------------------------------------------------
Review request for cloudstack, Chiradeep Vittal and Devdeep Singh.
Repository: cloudstack-git
Description
-------
Fix non-systemVM execution. ListTemplateCommand and ListVolumeCommand need to return the corresponding Answer object.
No bug was logged.
Diffs
-----
services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java 89ce8e009a36df53f10efda8ef7c3d8f7ed6e2dc
Diff: https://reviews.apache.org/r/13376/diff/
Testing
-------
Integration test: launched mgmt srvr with Quick Cloud configuration, launched QuickCloud secondary storage server, verified that no exceptions no longer occurred when secondary storage server connected to mgmt server.
Thanks,
Donal Lafferty
Re: Review Request 13376: Fix QuickCloud secondary storage service
ListTemplateCommand and ListVolumeCommand
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13376/#review24814
-----------------------------------------------------------
Ship it!
In the future, please format patches so that they can be applied using git am (authorship info is maintained if you do this).
This one has been applied using
git apply-patch and git commit -s --author="Donal Lafferty <do...@citrix.com>" -m "Get QuickCloud working again"
- Chiradeep Vittal
On Aug. 7, 2013, 1:49 p.m., Donal Lafferty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13376/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 1:49 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal and Devdeep Singh.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix non-systemVM execution. ListTemplateCommand and ListVolumeCommand need to return the corresponding Answer object.
>
> No bug was logged.
>
>
> Diffs
> -----
>
> services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java 89ce8e009a36df53f10efda8ef7c3d8f7ed6e2dc
>
> Diff: https://reviews.apache.org/r/13376/diff/
>
>
> Testing
> -------
>
> Integration test: launched mgmt srvr with Quick Cloud configuration, launched QuickCloud secondary storage server, verified that no exceptions no longer occurred when secondary storage server connected to mgmt server.
>
>
> Thanks,
>
> Donal Lafferty
>
>