You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bigtop.apache.org by "Evans Ye (JIRA)" <ji...@apache.org> on 2018/01/31 14:02:00 UTC

[jira] [Commented] (BIGTOP-2922) Drop arch specific bigtop-* images

    [ https://issues.apache.org/jira/browse/BIGTOP-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346873#comment-16346873 ] 

Evans Ye commented on BIGTOP-2922:
----------------------------------

Patch looks great [~jun.he]. Sorry for taking so long to review it.

Just one thing: can we switch to switch-case to determine OS and and the pkg management scripts? if-else definitely works but switch-case yield better readability in this case. 

> Drop arch specific bigtop-* images
> ----------------------------------
>
>                 Key: BIGTOP-2922
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2922
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: build, docker, tests
>            Reporter: Jun He
>            Assignee: Jun He
>            Priority: Major
>         Attachments: BIGTOP-2922.0.patch, build.sh, manifest.sh
>
>
> As docker hub has enabled multi-arch for main distros ([Ubuntu|https://hub.docker.com/_/ubuntu/], [Fedora|https://hub.docker.com/_/fedora/],
>  [Debian|https://hub.docker.com/_/debian/]), those arch specific docker images can be merged to unified one, like bigtop-puppet:ubuntu-16.04, and etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)