You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Maron <jm...@hortonworks.com> on 2015/05/11 16:01:14 UTC
Review Request 34039: atlas version should not include 0.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34039/
-----------------------------------------------------------
Review request for Ambari and Robert Levas.
Repository: ambari
Description
-------
Removed ".0.0" suffix from Atlas version (both directory name and referenced version)
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml 4c74a00
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py befde7b
Diff: https://reviews.apache.org/r/34039/diff/
Testing
-------
Re-ran the Ambari unit tests
Thanks,
Jonathan Maron
Re: Review Request 34039: atlas version should not include 0.0
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34039/#review83223
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On May 11, 2015, 10:19 a.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34039/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10:19 a.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed ".0.0" suffix from Atlas version (both directory name and referenced version)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json 7202950
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml e774f3b
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml aed76ff
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json 210f414
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml c26beb6
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml c80b10f
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py a4274ca
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py 94a8f9e
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py 8401a5d
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py 2144f71
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py 1ecb795
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py aa7f614
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/metadata-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/files/log4j.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/properties_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml 4c74a00
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py befde7b
>
> Diff: https://reviews.apache.org/r/34039/diff/
>
>
> Testing
> -------
>
> Re-ran the Ambari unit tests
>
>
> Thanks,
>
> Jonathan Maron
>
>
Re: Review Request 34039: atlas version should not include 0.0
Posted by Jonathan Maron <jm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34039/
-----------------------------------------------------------
(Updated May 11, 2015, 2:19 p.m.)
Review request for Ambari and Robert Levas.
Changes
-------
Uploaded a more detailed diff file since the first seemed to lack renamed/moved files.
Repository: ambari
Description
-------
Removed ".0.0" suffix from Atlas version (both directory name and referenced version)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json 7202950
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml e774f3b
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml aed76ff
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json 210f414
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml c26beb6
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml c80b10f
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py a4274ca
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py 94a8f9e
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py 8401a5d
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py 2144f71
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py 1ecb795
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py aa7f614
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/metadata-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/files/log4j.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/properties_config.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml 4c74a00
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py befde7b
Diff: https://reviews.apache.org/r/34039/diff/
Testing
-------
Re-ran the Ambari unit tests
Thanks,
Jonathan Maron
Re: Review Request 34039: atlas version should not include 0.0
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34039/#review83222
-----------------------------------------------------------
Ship it!
common-services/ATLAS/0.1.0.2.3_.0.0_/metainfo.xml:25 should be changed to reflect the new version value. @Jon claims it was. We are not sure why the diff is not being shown.
- Robert Levas
On May 11, 2015, 10:01 a.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34039/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 10:01 a.m.)
>
>
> Review request for Ambari and Robert Levas.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Removed ".0.0" suffix from Atlas version (both directory name and referenced version)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml 4c74a00
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py befde7b
>
> Diff: https://reviews.apache.org/r/34039/diff/
>
>
> Testing
> -------
>
> Re-ran the Ambari unit tests
>
>
> Thanks,
>
> Jonathan Maron
>
>