You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2016/09/06 15:36:36 UTC
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4317
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
IMPALA-3491: Use unique database fixture in test_insert_parquet.py
Testing: Ran the test locally in a loop.
Did a private debug/core/hdfs build.
Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
---
M testdata/workloads/tpch/queries/insert_parquet.test
M tests/query_test/test_insert_parquet.py
2 files changed, 16 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/4317/1
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
Patch Set 1:
ACK'ing that I've seen this review.
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Minor comments re: typos and variable names. Otherwise, super straightforward.
http://gerrit.cloudera.org:8080/#/c/4317/1/tests/query_test/test_insert_parquet.py
File tests/query_test/test_insert_parquet.py:
PS1, Line 123: i
Minor: Remore trailing "i"
PS1, Line 128: CREATE
Minor: by PEP-8 style convention, globally-scoped constants get all caps in python, local variables are lowercased. We have so many PEP-8 violations in our python though, it's probably not worth the effort to change this in any one place, but I'll just mention it for the record. (OTOH, it does seem weird that we are inconsistent, even within the scope of this one method.)
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
IMPALA-3491: Use unique database fixture in test_insert_parquet.py
Testing: Ran the test locally in a loop.
Did a private debug/core/hdfs build.
Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Reviewed-on: http://gerrit.cloudera.org:8080/4317
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M testdata/workloads/tpch/queries/insert_parquet.test
M tests/query_test/test_insert_parquet.py
2 files changed, 25 insertions(+), 39 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4317/1/tests/query_test/test_insert_parquet.py
File tests/query_test/test_insert_parquet.py:
PS1, Line 123: i
> Minor: Remore trailing "i"
Done
PS1, Line 128: CREATE
> Minor: by PEP-8 style convention, globally-scoped constants get all caps in
I'm not super familiar with the PEP-8 convention, so it does help if you point out violations :)
Happy to fix at least this file.
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
Patch Set 1:
David Knupp, want to take this?
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test insert parquet.py
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Hello David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4317
to look at the new patch set (#2).
Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py
......................................................................
IMPALA-3491: Use unique database fixture in test_insert_parquet.py
Testing: Ran the test locally in a loop.
Did a private debug/core/hdfs build.
Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
---
M testdata/workloads/tpch/queries/insert_parquet.test
M tests/query_test/test_insert_parquet.py
2 files changed, 25 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/4317/2
--
To view, visit http://gerrit.cloudera.org:8080/4317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>