You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/15 15:42:19 UTC
[GitHub] [incubator-apisix] Miss-you opened a new pull request #1848: [doc] remove the CODE_STYLE.md ref
Miss-you opened a new pull request #1848:
URL: https://github.com/apache/incubator-apisix/pull/1848
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Remove the CODE_STYLE.md ref which would cause invalid reference.
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on a change in pull request #1848: [doc] remove the CODE_STYLE.md ref
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1848:
URL: https://github.com/apache/incubator-apisix/pull/1848#discussion_r456985401
##########
File path: Contributing.md
##########
@@ -94,7 +94,7 @@ Once we've discussed your changes and you've got your code ready, make sure that
## Check code style and test case style
* code style
- * Please take a look at [OpenResty Lua Coding Style Guide](CODE_STYLE.md).
+ * Please take a look at [Lua Coding Style Guide](https://github.com/luarocks/lua-style-guide).
Review comment:
we can still using https://github.com/apache/incubator-apisix/blob/v1.3/CODE_STYLE.md, and remove all `openresty` in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming closed pull request #1848: [doc] remove the CODE_STYLE.md ref
Posted by GitBox <gi...@apache.org>.
moonming closed pull request #1848:
URL: https://github.com/apache/incubator-apisix/pull/1848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming commented on a change in pull request #1848: [doc] remove the CODE_STYLE.md ref
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1848:
URL: https://github.com/apache/incubator-apisix/pull/1848#discussion_r457813333
##########
File path: Contributing.md
##########
@@ -94,7 +94,7 @@ Once we've discussed your changes and you've got your code ready, make sure that
## Check code style and test case style
* code style
- * Please take a look at [OpenResty Lua Coding Style Guide](CODE_STYLE.md).
+ * Please take a look at [Lua Coding Style Guide](https://github.com/luarocks/lua-style-guide).
Review comment:
fixed by https://github.com/apache/incubator-apisix/pull/1874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on a change in pull request #1848: [doc] remove the CODE_STYLE.md ref
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1848:
URL: https://github.com/apache/incubator-apisix/pull/1848#discussion_r455659035
##########
File path: Contributing.md
##########
@@ -94,7 +94,7 @@ Once we've discussed your changes and you've got your code ready, make sure that
## Check code style and test case style
* code style
- * Please take a look at [OpenResty Lua Coding Style Guide](CODE_STYLE.md).
+ * Please take a look at [Lua Coding Style Guide](https://github.com/luarocks/lua-style-guide).
Review comment:
we do not use `luarocks Lua style`, the indented is 3 spaces.
but we are using 4 spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] Miss-you commented on a change in pull request #1848: [doc] remove the CODE_STYLE.md ref
Posted by GitBox <gi...@apache.org>.
Miss-you commented on a change in pull request #1848:
URL: https://github.com/apache/incubator-apisix/pull/1848#discussion_r458270528
##########
File path: Contributing.md
##########
@@ -94,7 +94,7 @@ Once we've discussed your changes and you've got your code ready, make sure that
## Check code style and test case style
* code style
- * Please take a look at [OpenResty Lua Coding Style Guide](CODE_STYLE.md).
+ * Please take a look at [Lua Coding Style Guide](https://github.com/luarocks/lua-style-guide).
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org