You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/12 14:13:04 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #11458: [Feature][Style] Enable spotless to manage imports
EricGao888 opened a new pull request, #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458
## Purpose of the pull request
* Enable spotless to manage `imports`.
* This PR closes: #11457
## Brief change log
1. Configure `Spotless` to remove unused `imports`.
2. Configure `Spotless` to sort `imports` in better order (instead of simply sorting import alphabetically).
3. Configure `Spotless` to remove wildcards imports.
## Verify this pull request
* Verified by manual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r944610512
##########
style/eclipse.importorder:
##########
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#Organize Import Order
+0=java
+1=javax
+2=org
+3=com
Review Comment:
If we hope to manage the import order, it's better to use the origin order
```
org.apache.dolphinscheduler,org.apache,java,javax,org,com
```
otherwise, the default order is still ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r946263982
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
> > This removes the star import. But will it instead replaces the star import with the used specific class import? If not, this will cause compiling failed. Can you change a class with this example?
>
> @kezhenxu94 Just a follow-up, as I've tested it locally, if we use `mvn spotless:check` instead of `mvn spotless:apply`, it only blocks the `wildcard imports` without removing them. To improve, we could change the pre-commit hook from `mvn spotless:apply` to `mvn spotless:check` and add an output message to inform contributors that they should remove `wildcard imports`. WDYT?
Can you identify the failure of `spotless:check` is because of `wildcard imports` or other code style issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r946263487
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
> This removes the star import. But will it instead replaces the star import with the used specific class import? If not, this will cause compiling failed. Can you change a class with this example?
@kezhenxu94 Just a follow-up, as I've tested it locally, if we use `mvn spotless:check` instead of `mvn spotless:apply`, it only blocks the `wildcard imports` without removing them. To improve, we could change the pre-commit hook from `mvn spotless:apply` to `mvn spotless:check` and add an output message to inform contributors that they should remove `wildcard imports`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 merged pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 merged PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945076546
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
@kezhenxu94 https://github.com/diffplug/spotless/issues/649#issuecomment-662739583 It is hardly possible for `Spotless` to replace with `wildcards` with `specific imports`, thus this is some kind of workaround actually. To prevent developers from pushing the commits without knowing that `wildcards` has been removed by their pre-commit hook, one possible solution is to add a message in pre-commit hook to inform them of this behavior. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945006780
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
This removes the star import. But will it instead replaces the star import with the used specific class import? If not, this will cause compiling failed. Can you change a class with this example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r944612568
##########
style/eclipse.importorder:
##########
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#Organize Import Order
+0=java
+1=javax
+2=org
+3=com
Review Comment:
> If we hope to manage the import order, it's better to use the origin order
>
> ```
> org.apache.dolphinscheduler,org.apache,java,javax,org,com
> ```
>
> otherwise, the default order is still ok.
Sure, I will give a try. If not work, will recover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#issuecomment-1213194846
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11458)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r946265943
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
@kezhenxu94 Yes, I just double-checked it. To reproduce, you might change https://github.com/apache/dolphinscheduler/blob/68316f68fa9b90560846c3a12274edec2bf5d960/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java#L33-L35 to `import java.util.*;` and run `mvn spotless:check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#issuecomment-1213312219
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11458)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#issuecomment-1213311663
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11458)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r944515507
##########
style/eclipse.importorder:
##########
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#Organize Import Order
+0=java
+1=javax
+2=org
+3=com
Review Comment:
FYI, we could not have an empty line at the end of this file because it would cause `Spotless` to fail to parse the `imports management` rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r946266668
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
> @kezhenxu94 Yes, I just double-checked it. To reproduce, you might change
>
> https://github.com/apache/dolphinscheduler/blob/68316f68fa9b90560846c3a12274edec2bf5d960/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java#L33-L35
>
> to `import java.util.*;` and run `mvn spotless:check`.
How can yo tell the `spotless:check` failure is because of wildcard import, if I have other code style issues and no wildcard import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945087368
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
FYI, I also added a comment in the origin issue to seek help: https://github.com/diffplug/spotless/issues/649#issuecomment-1213743932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945087368
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
@kezhenxu94 FYI, I also added a comment in the origin issue to seek help to see if there is some good practice to handle `wildcard imports` with `Spotless`: https://github.com/diffplug/spotless/issues/649#issuecomment-1213743932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#issuecomment-1213194340
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11458)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11458&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11458&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r944618991
##########
style/eclipse.importorder:
##########
@@ -0,0 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#Organize Import Order
+0=java
+1=javax
+2=org
+3=com
Review Comment:
@ruanwenjun Updated. It works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r946267701
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
> > @kezhenxu94 Yes, I just double-checked it. To reproduce, you might change
> > https://github.com/apache/dolphinscheduler/blob/68316f68fa9b90560846c3a12274edec2bf5d960/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java#L33-L35
> >
> > to `import java.util.*;` and run `mvn spotless:check`.
>
> How can yo tell the `spotless:check` failure is because of wildcard import, if I have other code style issues and no wildcard import?
Good question, since each rule has its name, I think there might be a way to configure `Spotless` to explicitly tell which rule the code fails. I will take a look and see if there is a way to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11458: [Feature][Style] Enable spotless to manage imports
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945106874
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
> @kezhenxu94 FYI, I also added a comment in the origin issue to seek help to see if there is some good practice to handle `wildcard imports` with `Spotless`: https://github.com/diffplug/spotless/issues/649#issuecomment-1213743932
Wow. The issue has been 2 years...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org