You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "binzhaomobile (JIRA)" <ji...@apache.org> on 2017/06/20 06:32:00 UTC
[jira] [Created] (ROCKETMQ-229) Name Server related conception
should't appear in rocketmq-remoting module
binzhaomobile created ROCKETMQ-229:
--------------------------------------
Summary: Name Server related conception should't appear in rocketmq-remoting module
Key: ROCKETMQ-229
URL: https://issues.apache.org/jira/browse/ROCKETMQ-229
Project: Apache RocketMQ
Issue Type: Bug
Components: rocketmq-remoting
Affects Versions: 4.1.0-incubating, 4.2.0-incubating, 4.3.0-incubating
Environment: All Environments
Reporter: binzhaomobile
Assignee: vongosling
Priority: Minor
Currently in rocketmq-remoting, there are some NameServer related member variable and member functions.
such as:
---------------------------------------------------------------------------------------------------------------
private final AtomicReference<List<String>> namesrvAddrList = new AtomicReference<>();
private final AtomicReference<String> namesrvAddrChoosed = new AtomicReference<>();
private final AtomicInteger namesrvIndex = new AtomicInteger(initValueIndex());
private final Lock lockNamesrvChannel = new ReentrantLock();
public void updateNameServerAddressList(final List<String> addrs);
public List<String> getNameServerAddressList();
------------------------------------------------------------------------------------------------------------------
As an underlying network communication module, rocketmq-remoting should not know the concept of "Name Server". The NameServer related code should better be refactored into common module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)