You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2008/02/25 22:12:49 UTC
[PATCH] consistent function formatting for libsvn_ra
Hi,
libsvn_ra has mixed function declaration styles.
Some functions are declared as:
return_value function(...
and others as:
return_value
function(...
The attached patch changes all function declarations to the
latter style, which is also recommended in the hacker's guide.
OK to commit?
[[[
* subversion/libsvn_ra/wrapper_template.h,
subversion/libsvn_ra/ra_loader.c: Reformat all function declarations
to the style recommended in the hacker's guide. Some functions in
these files were already formatted this way.
]]]
Thanks,
--
Stefan Sperling <st...@elego.de> Software Developer
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by David Glasser <gl...@davidglasser.net>.
On Mon, Mar 3, 2008 at 11:42 AM, Erik Huelsmann <eh...@gmail.com> wrote:
> On Mon, Mar 3, 2008 at 8:33 PM, Branko Čibej <br...@xbc.nu> wrote:
> > Karl Fogel wrote:
> > > Stefan Sperling <st...@elego.de> writes:
> > >
> > >> If blame information is really that important, we should scratch the
> > >> patch altogether. Otherwise I'd still rather opt for consistent style.
> > >>
> > >> I stumbled across this because Steve is looking into adding code to
> > >> one of the files in question, and we could not figure out the correct
> > >> style to use for new code.
> > >>
> > >> So I asked in IRC what style new code should use. Erik Huelsmann said
> > >> the project was aiming at keeping the style consistent within modules.
> > >> Since libsvn_ra's style is totally ambiguous, I created the patch to
> > >> make it consistent.
> > >>
> > >> So, for me, it's not about being tidy for the sake of it, but because
> > >> of the benefits consistency provides when adding or modying code.
> > >>
> > >
> > > I think consistency is worth it too. Maybe apply this after 1.5 is
> > > released?
> > >
> >
> > ... after which there will be no more backports?
> >
> > "A foolish consistency" etc. I vote we leave well enough alone.
>
> We reformatted *all* our sources (remember Subversion-with-space?). I
> really don't get you all (not you personally) keep talking about
> backporting problems. We're *not* a closed source project with 115
> variants for different customers we need to support until 2030; we
> only have 1 or 2 active release branches: the cost of backporting is
> only 2, not 115.
+1.
Especially since these are *not* rapidly changing files. We only
change them when we incompatibly alter the signatures of RA APIs, and
any backport of such a change is likely to be otherwise annoying
anyway.
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by Erik Huelsmann <eh...@gmail.com>.
On Mon, Mar 3, 2008 at 8:33 PM, Branko Čibej <br...@xbc.nu> wrote:
> Karl Fogel wrote:
> > Stefan Sperling <st...@elego.de> writes:
> >
> >> If blame information is really that important, we should scratch the
> >> patch altogether. Otherwise I'd still rather opt for consistent style.
> >>
> >> I stumbled across this because Steve is looking into adding code to
> >> one of the files in question, and we could not figure out the correct
> >> style to use for new code.
> >>
> >> So I asked in IRC what style new code should use. Erik Huelsmann said
> >> the project was aiming at keeping the style consistent within modules.
> >> Since libsvn_ra's style is totally ambiguous, I created the patch to
> >> make it consistent.
> >>
> >> So, for me, it's not about being tidy for the sake of it, but because
> >> of the benefits consistency provides when adding or modying code.
> >>
> >
> > I think consistency is worth it too. Maybe apply this after 1.5 is
> > released?
> >
>
> ... after which there will be no more backports?
>
> "A foolish consistency" etc. I vote we leave well enough alone.
We reformatted *all* our sources (remember Subversion-with-space?). I
really don't get you all (not you personally) keep talking about
backporting problems. We're *not* a closed source project with 115
variants for different customers we need to support until 2030; we
only have 1 or 2 active release branches: the cost of backporting is
only 2, not 115.
bye,
Erik who votes for consistency.
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by Branko Čibej <br...@xbc.nu>.
Karl Fogel wrote:
> Stefan Sperling <st...@elego.de> writes:
>
>> If blame information is really that important, we should scratch the
>> patch altogether. Otherwise I'd still rather opt for consistent style.
>>
>> I stumbled across this because Steve is looking into adding code to
>> one of the files in question, and we could not figure out the correct
>> style to use for new code.
>>
>> So I asked in IRC what style new code should use. Erik Huelsmann said
>> the project was aiming at keeping the style consistent within modules.
>> Since libsvn_ra's style is totally ambiguous, I created the patch to
>> make it consistent.
>>
>> So, for me, it's not about being tidy for the sake of it, but because
>> of the benefits consistency provides when adding or modying code.
>>
>
> I think consistency is worth it too. Maybe apply this after 1.5 is
> released?
>
... after which there will be no more backports?
"A foolish consistency" etc. I vote we leave well enough alone.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by David Glasser <gl...@davidglasser.net>.
On Wed, Feb 27, 2008 at 2:13 PM, Karl Fogel <kf...@red-bean.com> wrote:
> Stefan Sperling <st...@elego.de> writes:
> > If blame information is really that important, we should scratch the
> > patch altogether. Otherwise I'd still rather opt for consistent style.
> >
> > I stumbled across this because Steve is looking into adding code to
> > one of the files in question, and we could not figure out the correct
> > style to use for new code.
> >
> > So I asked in IRC what style new code should use. Erik Huelsmann said
> > the project was aiming at keeping the style consistent within modules.
> > Since libsvn_ra's style is totally ambiguous, I created the patch to
> > make it consistent.
> >
> > So, for me, it's not about being tidy for the sake of it, but because
> > of the benefits consistency provides when adding or modying code.
>
> I think consistency is worth it too. Maybe apply this after 1.5 is
> released?
We really don't change the RA loader *that* often. How many RA *API*
changes do you expect will show up in 1.5 that we haven't done yet? I
think this is fine for trunk now.
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by Stefan Sperling <st...@elego.de>.
On Wed, Feb 27, 2008 at 05:13:55PM -0500, Karl Fogel wrote:
> Stefan Sperling <st...@elego.de> writes:
> > If blame information is really that important, we should scratch the
> > patch altogether. Otherwise I'd still rather opt for consistent style.
> >
> > I stumbled across this because Steve is looking into adding code to
> > one of the files in question, and we could not figure out the correct
> > style to use for new code.
> >
> > So I asked in IRC what style new code should use. Erik Huelsmann said
> > the project was aiming at keeping the style consistent within modules.
> > Since libsvn_ra's style is totally ambiguous, I created the patch to
> > make it consistent.
> >
> > So, for me, it's not about being tidy for the sake of it, but because
> > of the benefits consistency provides when adding or modying code.
>
> I think consistency is worth it too. Maybe apply this after 1.5 is
> released?
I'll bump this thread again when 1.5 is released.
(/me makes a mental note and hopes not to forget about it...)
--
Stefan Sperling <st...@elego.de> Software Developer
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by Karl Fogel <kf...@red-bean.com>.
Stefan Sperling <st...@elego.de> writes:
> If blame information is really that important, we should scratch the
> patch altogether. Otherwise I'd still rather opt for consistent style.
>
> I stumbled across this because Steve is looking into adding code to
> one of the files in question, and we could not figure out the correct
> style to use for new code.
>
> So I asked in IRC what style new code should use. Erik Huelsmann said
> the project was aiming at keeping the style consistent within modules.
> Since libsvn_ra's style is totally ambiguous, I created the patch to
> make it consistent.
>
> So, for me, it's not about being tidy for the sake of it, but because
> of the benefits consistency provides when adding or modying code.
I think consistency is worth it too. Maybe apply this after 1.5 is
released?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by Stefan Sperling <st...@elego.de>.
On Mon, Feb 25, 2008 at 02:21:03PM -0800, Blair Zajac wrote:
> Also, I think it would be best of hold off on whitespace and formatting
> changes until 1.5 is released.
Agreed, delaying this until after 1.5 release to keep diffs concise
while a lot of backporting is still being done might be a good idea.
On Mon, Feb 25, 2008 at 05:52:38PM -0500, Karl Fogel wrote:
> I'm not sure the blame-information loss is worth a bit of extra tidiness.
Mmmh. Good point also.
If blame information is really that important, we should scratch the
patch altogether. Otherwise I'd still rather opt for consistent style.
I stumbled across this because Steve is looking into adding code to
one of the files in question, and we could not figure out the correct
style to use for new code.
So I asked in IRC what style new code should use. Erik Huelsmann said
the project was aiming at keeping the style consistent within modules.
Since libsvn_ra's style is totally ambiguous, I created the patch to
make it consistent.
So, for me, it's not about being tidy for the sake of it, but because
of the benefits consistency provides when adding or modying code.
--
Stefan Sperling <st...@elego.de> Software Developer
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by Karl Fogel <kf...@red-bean.com>.
Blair Zajac <bl...@orcaware.com> writes:
> I find that only to be an issue for long function names which cause
> lines to wrap over 80 characters, otherwise I leave the style alone.
Yeah, it's true that we're inconsistent, which is unfortunate, but I'm
not sure the blame-information loss is worth a bit of extra tidiness.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] consistent function formatting for libsvn_ra
Posted by Blair Zajac <bl...@orcaware.com>.
Stefan Sperling wrote:
> Hi,
>
> libsvn_ra has mixed function declaration styles.
>
> Some functions are declared as:
>
> return_value function(...
>
> and others as:
>
> return_value
> function(...
>
> The attached patch changes all function declarations to the
> latter style, which is also recommended in the hacker's guide.
>
> OK to commit?
I find that only to be an issue for long function names which cause lines to
wrap over 80 characters, otherwise I leave the style alone.
Also, I think it would be best of hold off on whitespace and formatting changes
until 1.5 is released.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org