You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/08 02:26:11 UTC
[GitHub] [iotdb] yifuzhou opened a new pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
yifuzhou opened a new pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372
## Description
### Content1 ...
### Content2 ...
### Content3 ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-856405879
[](https://coveralls.io/builds/40383855)
Coverage decreased (-0.03%) to 67.91% when pulling **d4437ccc34b056c5d2a5425f95836849da8d25ab on yifuzhou:IOTDB-1425** into **80f5afffb6219aba01cc05b9ef80e465ea1d8870 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-856405879
[](https://coveralls.io/builds/40384866)
Coverage decreased (-0.02%) to 67.923% when pulling **2b31fdfa38164f8ead275399e51dcd3a632e87ee on yifuzhou:IOTDB-1425** into **80f5afffb6219aba01cc05b9ef80e465ea1d8870 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on a change in pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on a change in pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#discussion_r647902292
##########
File path: server/src/main/java/org/apache/iotdb/db/auth/AuthorityChecker.java
##########
@@ -138,6 +140,7 @@ private static int translateToPermissionId(Operator.OperatorType type) {
case INSERT:
case LOADDATA:
case CREATE_INDEX:
+ case ALTER_TIMESERIES:
return PrivilegeType.INSERT_TIMESERIES.ordinal();
Review comment:
Can you tell me the place that I can mention it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-856405879
[](https://coveralls.io/builds/40385780)
Coverage decreased (-0.04%) to 67.903% when pulling **2b31fdfa38164f8ead275399e51dcd3a632e87ee on yifuzhou:IOTDB-1425** into **80f5afffb6219aba01cc05b9ef80e465ea1d8870 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3372: [IOTDB-1425]Privilege controller does not support delete_sg, alter_ts, and TTL operators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-856405879
[](https://coveralls.io/builds/40472023)
Coverage decreased (-0.2%) to 67.753% when pulling **71b4889c3fa4148868e853dd8578f27c4c210042 on yifuzhou:IOTDB-1425** into **80f5afffb6219aba01cc05b9ef80e465ea1d8870 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #3372: [IOTDB-1425]Privilege controller does not support delete_sg, alter_ts, and TTL operators
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#discussion_r648064276
##########
File path: server/src/main/java/org/apache/iotdb/db/auth/entity/PrivilegeType.java
##########
@@ -46,6 +45,7 @@
DROP_TRIGGER,
START_TRIGGER,
STOP_TRIGGER,
+ TTL,
ALL;
Review comment:
> All new privileges should be appended to the tail as they are serialized according to their ordinals, changing the order may introduce compatibility problems.
So why you approve the PR though it is not changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on a change in pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on a change in pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#discussion_r647902071
##########
File path: server/src/main/java/org/apache/iotdb/db/auth/entity/PrivilegeType.java
##########
@@ -46,6 +45,7 @@
DROP_TRIGGER,
START_TRIGGER,
STOP_TRIGGER,
+ TTL,
ALL;
Review comment:
I mentioned this new privilege in docs/UserGuide/Administration-Management/Administration.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-856405879
[](https://coveralls.io/builds/40384358)
Coverage decreased (-0.01%) to 67.929% when pulling **d4437ccc34b056c5d2a5425f95836849da8d25ab on yifuzhou:IOTDB-1425** into **80f5afffb6219aba01cc05b9ef80e465ea1d8870 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3372: [IOTDB-1425]Privilege controller does not support delete_sg, alter_ts, and TTL operators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-856405879
[](https://coveralls.io/builds/40810060)
Coverage decreased (-0.05%) to 67.889% when pulling **596e0d1d3fab37d21e5d7d07a3df011f92382d96 on yifuzhou:IOTDB-1425** into **80f5afffb6219aba01cc05b9ef80e465ea1d8870 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on pull request #3372: [IOTDB-1425]Privilege controller does not support delete_sg, alter_ts, and TTL operators
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-866574437
> > All new privileges should be appended to the tail as they are serialized according to their ordinals, changing the order may introduce compatibility problems.
>
> Why this is omitted..
Done. I move new privileges to the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3372: [IOTDB-1425]Privilege controller does not support delete_sg, alter_ts, and TTL operators
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-856405879
[](https://coveralls.io/builds/40812440)
Coverage decreased (-0.04%) to 67.9% when pulling **e0f03dde0448df982d0266ae00dbc5fbd7b69c02 on yifuzhou:IOTDB-1425** into **80f5afffb6219aba01cc05b9ef80e465ea1d8870 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on pull request #3372: [IOTDB-1425]Privilege controller does not support delete_sg, alter_ts, and TTL operators
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-858437673
> > All new privileges should be appended to the tail as they are serialized according to their ordinals, changing the order may introduce compatibility problems.
>
> Why this is omitted..
You mean add after 'ALL'? I see other pr added the privilege type at the end but before 'ALL', I think it is more reasonable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on pull request #3372: [IOTDB-1425]Privilege controller does not support delete_sg, alter_ts, and TTL operators
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#issuecomment-858210723
> Test needed. (coverage of new codes >=80%)
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jt2594838 commented on a change in pull request #3372: [IOTDB-1425]Privilege controller does not support some operators
Posted by GitBox <gi...@apache.org>.
jt2594838 commented on a change in pull request #3372:
URL: https://github.com/apache/iotdb/pull/3372#discussion_r647343305
##########
File path: server/src/main/java/org/apache/iotdb/db/auth/AuthorityChecker.java
##########
@@ -138,6 +140,7 @@ private static int translateToPermissionId(Operator.OperatorType type) {
case INSERT:
case LOADDATA:
case CREATE_INDEX:
+ case ALTER_TIMESERIES:
return PrivilegeType.INSERT_TIMESERIES.ordinal();
Review comment:
This should be pointed out in the document that altering a timeseries requires a write privilege.
##########
File path: server/src/main/java/org/apache/iotdb/db/auth/entity/PrivilegeType.java
##########
@@ -46,6 +45,7 @@
DROP_TRIGGER,
START_TRIGGER,
STOP_TRIGGER,
+ TTL,
ALL;
Review comment:
All new privileges should be appended to the tail as they are serialized according to their ordinals, changing the order may introduce compatibility problems.
##########
File path: server/src/main/java/org/apache/iotdb/db/auth/entity/PrivilegeType.java
##########
@@ -46,6 +45,7 @@
DROP_TRIGGER,
START_TRIGGER,
STOP_TRIGGER,
+ TTL,
ALL;
Review comment:
By the way, have you mentioned the new privileges in the document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org