[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7934: Power of 2 fixed size chunks

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7934:
URL: https://github.com/apache/pinot/pull/7934#discussion_r772746860



##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/FixedByteChunkSVForwardIndexWriter.java
##########
@@ -112,4 +113,12 @@ private void flushChunkIfNeeded() {
       writeChunk();
     }
   }
+
+  private static int normalizeChunkSize(int version, int numDocsPerChunk) {

Review comment:
       (minor) `normalizeDocsPerChunk` to be more clear?

##########
File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java
##########
@@ -65,12 +65,14 @@
    * @param chunkSize Size of chunk
    * @param sizeOfEntry Size of entry (in bytes), max size for variable byte implementation.
    * @param version version of File
+   * @param fixed if the data type is fixed width (required for version validation)
    * @throws IOException if the file isn't found or can't be mapped
    */
   protected BaseChunkSVForwardIndexWriter(File file, ChunkCompressionType compressionType, int totalDocs,
-      int numDocsPerChunk, int chunkSize, int sizeOfEntry, int version)
+      int numDocsPerChunk, int chunkSize, int sizeOfEntry, int version, boolean fixed)

Review comment:
       I don't think we need this extra `fixed` here for the version validation. Var-length V4 won't use this writer, but I don't think we should validate that here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org