You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Greg Huber <gr...@gmail.com> on 2013/04/05 15:02:53 UTC
Media file tags
Guys,
I could not get the Media file tags to save correctly. It seems someting
to to with JPA? I am expert on JAP.
Cheers Greg.
Re: Media file tags
Posted by Greg Huber <gr...@gmail.com>.
Glen,
Already fixed it. It needed rewriting as JPA could not handle saving the
Set<MediaFileTag> correctly, it could delete ok but was not able to work
out the changes. It would add to the set on subsequent updates. I used
the logic from the WeblogEntryTag as a basis for the fix.
r1465469
Cheers Greg
On 9 April 2013 17:42, Glen Mazza <gl...@gmail.com> wrote:
> Did you get this problem resolved? If not does it need a JIRA item or it
> already has one?
>
> Glen
>
> On 04/05/2013 09:02 AM, Greg Huber wrote:
>
>> Guys,
>>
>> I could not get the Media file tags to save correctly. It seems someting
>> to to with JPA? I am expert on JAP.
>>
>> Cheers Greg.
>>
>>
>
Re: Media file tags
Posted by Greg Huber <gr...@gmail.com>.
Glen,
I have committed the MediaFileTest.java: which now builds. r1466614.
Cheers Greg.
On 10 April 2013 19:11, Glen Mazza <gl...@gmail.com> wrote:
> Incidentally, the tests are failing with the latest media file change,
> "mvn clean install" outputs:
>
> [ERROR] Failed to execute goal org.apache.maven.plugins:**
> maven-compiler-plugin:2.0.2:**testCompile (default-testCompile) on
> project roller-weblogger-business: Compilation failure: Compilation failure:
> [ERROR] /media/work1/opensource/**roller-trunk/weblogger-**
> business/src/test/java/org/**apache/roller/weblogger/**
> business/MediaFileTest.java:[**325,17] error: setTags(Set<MediaFileTag>)
> has private access in MediaFile
> [ERROR]
> [ERROR] /media/work1/opensource/**roller-trunk/weblogger-**
> business/src/test/java/org/**apache/roller/weblogger/**
> business/MediaFileTest.java:[**400,17] error: setTags(Set<MediaFileTag>)
> has private access in MediaFile
> [ERROR]
> ... 4 more of the same errors in that class ...
>
> I can look at this later if you don't have time to get to it.
>
> Glen
>
> On 04/09/2013 12:42 PM, Glen Mazza wrote:
>
>>
>> On 04/05/2013 09:02 AM, Greg Huber wrote:
>>
>>> Guys,
>>>
>>> I could not get the Media file tags to save correctly. It seems someting
>>> to to with JPA? I am expert on JAP.
>>>
>>> Cheers Greg.
>>>
>>>
>>
>
Re: Media file tags
Posted by Greg Huber <gr...@gmail.com>.
Glen,
I will have a look.
Cheers Greg.
On 10 April 2013 19:11, Glen Mazza <gl...@gmail.com> wrote:
> Incidentally, the tests are failing with the latest media file change,
> "mvn clean install" outputs:
>
> [ERROR] Failed to execute goal org.apache.maven.plugins:**
> maven-compiler-plugin:2.0.2:**testCompile (default-testCompile) on
> project roller-weblogger-business: Compilation failure: Compilation failure:
> [ERROR] /media/work1/opensource/**roller-trunk/weblogger-**
> business/src/test/java/org/**apache/roller/weblogger/**
> business/MediaFileTest.java:[**325,17] error: setTags(Set<MediaFileTag>)
> has private access in MediaFile
> [ERROR]
> [ERROR] /media/work1/opensource/**roller-trunk/weblogger-**
> business/src/test/java/org/**apache/roller/weblogger/**
> business/MediaFileTest.java:[**400,17] error: setTags(Set<MediaFileTag>)
> has private access in MediaFile
> [ERROR]
> ... 4 more of the same errors in that class ...
>
> I can look at this later if you don't have time to get to it.
>
> Glen
>
> On 04/09/2013 12:42 PM, Glen Mazza wrote:
>
>>
>> On 04/05/2013 09:02 AM, Greg Huber wrote:
>>
>>> Guys,
>>>
>>> I could not get the Media file tags to save correctly. It seems someting
>>> to to with JPA? I am expert on JAP.
>>>
>>> Cheers Greg.
>>>
>>>
>>
>
Re: Media file tags
Posted by Glen Mazza <gl...@gmail.com>.
Incidentally, the tests are failing with the latest media file change,
"mvn clean install" outputs:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.0.2:testCompile
(default-testCompile) on project roller-weblogger-business: Compilation
failure: Compilation failure:
[ERROR]
/media/work1/opensource/roller-trunk/weblogger-business/src/test/java/org/apache/roller/weblogger/business/MediaFileTest.java:[325,17]
error: setTags(Set<MediaFileTag>) has private access in MediaFile
[ERROR]
[ERROR]
/media/work1/opensource/roller-trunk/weblogger-business/src/test/java/org/apache/roller/weblogger/business/MediaFileTest.java:[400,17]
error: setTags(Set<MediaFileTag>) has private access in MediaFile
[ERROR]
... 4 more of the same errors in that class ...
I can look at this later if you don't have time to get to it.
Glen
On 04/09/2013 12:42 PM, Glen Mazza wrote:
>
> On 04/05/2013 09:02 AM, Greg Huber wrote:
>> Guys,
>>
>> I could not get the Media file tags to save correctly. It seems
>> someting
>> to to with JPA? I am expert on JAP.
>>
>> Cheers Greg.
>>
>
Re: Media file tags
Posted by Glen Mazza <gl...@gmail.com>.
Did you get this problem resolved? If not does it need a JIRA item or
it already has one?
Glen
On 04/05/2013 09:02 AM, Greg Huber wrote:
> Guys,
>
> I could not get the Media file tags to save correctly. It seems someting
> to to with JPA? I am expert on JAP.
>
> Cheers Greg.
>