You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/28 17:07:37 UTC

[GitHub] [beam] y1chi commented on a diff in pull request #22072: Fixes to release scripts from 2.40.0 release process

y1chi commented on code in PR #22072:
URL: https://github.com/apache/beam/pull/22072#discussion_r908744596


##########
release/src/main/scripts/preparation_before_release.sh:
##########
@@ -28,6 +28,16 @@ BEAM_REPO=beam
 
 cd ~
 
+echo "-----------------Checking svn installation-----------------"
+if [[ -z `which svn` ]]; then
+  echo "You don't have subversion (svn) installed."
+  echo "Please install it in a different terminal and press any key to continue."

Review Comment:
   do you need wait for prompt input here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org