You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/27 12:06:27 UTC

Review Request 34701: Fix Coverity Defects: Null pointer dereferences

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34701/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-11416
    https://issues.apache.org/jira/browse/AMBARI-11416


Repository: ambari


Description
-------

Fix Null pointer dereferences accordinly coverity scan report


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java cdfd72d 
  ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java 629fcba 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/JpaPredicateVisitor.java 75ca2d2 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManagerImpl.java 2013fe4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5b902d5 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java add4285 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 9707ec9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java c07bc17 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java d14c6b7 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java c86073f 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java 90e7ed3 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 4e2fbcd 
  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java e35e42b 
  ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 9e25dfb 
  ambari-server/src/main/java/org/apache/ambari/server/topology/RequiredPasswordValidator.java 870d718 
  ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 8796bd3 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 7395fa6 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java f8b3daf 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestActionQueue.java e431eee 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java 2daa273 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 00f9bed 
  ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java 1eaa9cc 
  ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java 61bce55 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java 410eced 
  ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java 9bf969c 
  ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java b9e4ff0 
  ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 83a8de6 

Diff: https://reviews.apache.org/r/34701/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 34701: Fix Coverity Defects: Null pointer dereferences

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34701/#review85355
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Травень 27, 2015, 10:06 до полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34701/
> -----------------------------------------------------------
> 
> (Updated Травень 27, 2015, 10:06 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11416
>     https://issues.apache.org/jira/browse/AMBARI-11416
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix Null pointer dereferences accordinly coverity scan report
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java cdfd72d 
>   ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java 629fcba 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/JpaPredicateVisitor.java 75ca2d2 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManagerImpl.java 2013fe4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5b902d5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java add4285 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java 9707ec9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java c07bc17 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java d14c6b7 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java c86073f 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java 90e7ed3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 4e2fbcd 
>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java e35e42b 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 9e25dfb 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/RequiredPasswordValidator.java 870d718 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 8796bd3 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 7395fa6 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java f8b3daf 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestActionQueue.java e431eee 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImplTest.java 2daa273 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 00f9bed 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java 1eaa9cc 
>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java 61bce55 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java 410eced 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java 9bf969c 
>   ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java b9e4ff0 
>   ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 83a8de6 
> 
> Diff: https://reviews.apache.org/r/34701/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>