You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@livy.apache.org by "askhatri (via GitHub)" <gi...@apache.org> on 2023/05/03 04:19:43 UTC
[GitHub] [incubator-livy] askhatri opened a new pull request, #404: [LIVY-974][SERVER] Remove verbose output on Livy UI error pages
askhatri opened a new pull request, #404:
URL: https://github.com/apache/incubator-livy/pull/404
## What changes were proposed in this pull request?
On error, the Livy UI shows verbose output on error pages including the Jetty version number. This could be considered as a security vulnerability. We can make it configurable and avoid sending server version details. The Jetty version is there in every response header as well.
JIRA: https://issues.apache.org/jira/browse/LIVY-974
## How was this patch tested?
Verified manually by calling get sessions via REST API call in a local Yarn cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LIVY-974][SERVER] Remove verbose output on Livy UI error pages [incubator-livy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #404:
URL: https://github.com/apache/incubator-livy/pull/404#issuecomment-3146560720
## [Codecov](https://app.codecov.io/gh/apache/incubator-livy/pull/404?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 29.08%. Comparing base ([`12505dd`](https://app.codecov.io/gh/apache/incubator-livy/commit/12505dd88fac4c2b9da92a020205ffb72524a9c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`88d1db9`](https://app.codecov.io/gh/apache/incubator-livy/commit/88d1db9d1303a51b97165bbc6f38d0a5db2c11b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 28 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-livy/pull/404?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../main/scala/org/apache/livy/server/WebServer.scala](https://app.codecov.io/gh/apache/incubator-livy/pull/404?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Flivy%2Fserver%2FWebServer.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvV2ViU2VydmVyLnNjYWxh) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-livy/pull/404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #404 +/- ##
=============================================
- Coverage 65.97% 29.08% -36.90%
+ Complexity 835 375 -460
=============================================
Files 103 103
Lines 6063 6066 +3
Branches 913 913
=============================================
- Hits 4000 1764 -2236
- Misses 1536 3949 +2413
+ Partials 527 353 -174
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-livy/pull/404?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] gyogal merged pull request #404: [LIVY-974][SERVER] Remove verbose output on Livy UI error pages
Posted by "gyogal (via GitHub)" <gi...@apache.org>.
gyogal merged PR #404:
URL: https://github.com/apache/incubator-livy/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] askhatri commented on pull request #404: [LIVY-974][SERVER] Remove verbose output on Livy UI error pages
Posted by "askhatri (via GitHub)" <gi...@apache.org>.
askhatri commented on PR #404:
URL: https://github.com/apache/incubator-livy/pull/404#issuecomment-1534121722
> Contributor
Thank you @gyogal !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org