You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/30 16:32:45 UTC
[GitHub] azai91 commented on a change in pull request #12374: Fix/public
internal header
azai91 commented on a change in pull request #12374: Fix/public internal header
URL: https://github.com/apache/incubator-mxnet/pull/12374#discussion_r214098547
##########
File path: include/mxnet/random_generator.h
##########
@@ -150,14 +149,9 @@ class RandGenerator<gpu, DType> {
curandStatePhilox4_32_10_t state_;
}; // class RandGenerator<gpu, DType>::Impl
- static void AllocState(RandGenerator<gpu, DType> *inst) {
- CUDA_CALL(cudaMalloc(&inst->states_,
- kNumRandomStates * sizeof(curandStatePhilox4_32_10_t)));
- }
+ static void AllocState(RandGenerator<gpu, DType> *inst);
Review comment:
what does you mean? we are calling cudaMalloc in this case instead of just "new"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services