[GitHub] [skywalking-java] 2han9wen71an commented on a diff in pull request #448: Fix osgi environment not working

["2han9wen71an (via GitHub)" <gi...@apache.org>]

2han9wen71an commented on code in PR #448:
URL: https://github.com/apache/skywalking-java/pull/448#discussion_r1096482318


##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/AgentClassLoader.java:
##########
@@ -44,25 +40,57 @@
 /**
  * The <code>AgentClassLoader</code> represents a classloader, which is in charge of finding plugins and interceptors.
  */
-public class AgentClassLoader extends ClassLoader {
+public class AgentClassLoader extends URLClassLoader {
+    private static final ILog LOGGER;
+    /**
+     * Storage plug-in jar package url address
+     */
+    private static URL[] ARRAY_PLUGINS_URL;

Review Comment:
   `ARRAY_PLUGINS_URL` is because the plugin url is an array type, it is not as clear as `PLUGIN_JAR_URLS`, I will adjust it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org