You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by sijie <gi...@git.apache.org> on 2017/06/01 20:02:18 UTC
[GitHub] bookkeeper pull request #177: BOOKKEEPER-1087: Ledger Recovery - Add a paral...
GitHub user sijie opened a pull request:
https://github.com/apache/bookkeeper/pull/177
BOOKKEEPER-1087: Ledger Recovery - Add a parallel reading request in PendingReadOp
THIS CHANGE IS BASED ON #176 (you can review f0fb89c)
bookkeeper recovery improvement (part-2): add a parallel reading request in PendingReadOp
- add a parallel reading request in PendingReadOp
- allow PendingReadOp to configure whether to do parallel reading or not
- add flag in ClientConfiguration to allow configuring whether to do parallel reading in LedgerRecoveryOp or not.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sijie/bookkeeper recovery_improvements_part2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #177
----
commit 3db0b84570dec166855c70105a5cbf6f2ec14ea2
Author: Sijie Guo <si...@twitter.com>
Date: 2014-01-21T00:42:28Z
bookkeeper recovery improvement (part-1): refactor PendingReadOp
this change is the first part of improving bookkeeper recovery. it is basically a refactor change, which:
- abstract an interface for LedgerEntryRequest in PendingReadOp
- rename current implementation to SequenceReadRequest, which read the entry in the sequence of quorum.
RB_ID=266137
commit 80ffc6ca86b5e8a63dc3b9baf846ad139d7beea1
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T19:11:40Z
Address conflicts
commit f0fb89cbdfed6c6b0d519a25ea2ea67dcd72834e
Author: Sijie Guo <si...@twitter.com>
Date: 2014-01-21T00:49:52Z
bookkeeper recovery improvement (part-2): add a parallel reading request in PendingReadOp
- add a parallel reading request in PendingReadOp
- allow PendingReadOp to configure whether to do parallel reading or not
- add flag in ClientConfiguration to allow configuring whether to do parallel reading in LedgerRecoveryOp or not.
RB_ID=266139
commit db3e98ba9250b622db80cac8dd6dbd2761a32381
Author: Sijie Guo <si...@apache.org>
Date: 2017-06-01T20:00:01Z
Address conflicts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #177: BOOKKEEPER-1087: Ledger Recovery - Add a parallel rea...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/177
@sijie I have merged #176 maybe you will have to rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #177: BOOKKEEPER-1087: Ledger Recovery (part 2) - Ad...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #177: BOOKKEEPER-1087: Ledger Recovery - Add a parallel rea...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/177
@sijie got it. Sorry. I will only proceed with reviews. Just wanted to help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #177: BOOKKEEPER-1087: Ledger Recovery - Add a parallel rea...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/177
@eolivelli I think a better approach is to complete the reviews for all the sub-tasks for a given master JIRA before merging. otherwise, I have to rebase every time you merged.
for example, all the ledger recovery changes are sub-tasks of https://issues.apache.org/jira/browse/BOOKKEEPER-757. I haven't sent them out yet.
If you are okay, you can defer merging to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #177: BOOKKEEPER-1087: Ledger Recovery (part 2) - Add a par...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/177
All CI passed. Merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #177: BOOKKEEPER-1087: Ledger Recovery - Add a parallel rea...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/177
@merlimat @jvrao please review this. if there is no objections, I'd like to complete the ledger recovery changes and move on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---