You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:25:09 UTC
[GitHub] [flink] GuXiangFly opened a new pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
GuXiangFly opened a new pull request #16205:
URL: https://github.com/apache/flink/pull/16205
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This PR is to fix the following two issues only RocksDB:
https://issues.apache.org/jira/browse/FLINK-18464
https://issues.apache.org/jira/browse/FLINK-23036
## Brief change log
If the passed namespaceSerializer does not match the namespace, it should not serialize and should not write backendState
Sharing state between trigger and TimeWindow causes inconsistencies in the namespace and NamespaceSerializer
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers:yes
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864129076
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19147",
"triggerID" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"triggerType" : "PUSH"
}, {
"hash" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369",
"triggerID" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"triggerType" : "PUSH"
}, {
"hash" : "c25b08e49d9604f5316a599704dba02cd2fa2649",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c25b08e49d9604f5316a599704dba02cd2fa2649",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 984d9668ebb8f05c44ed00e4e70fe89205de1c94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369)
* c25b08e49d9604f5316a599704dba02cd2fa2649 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864129076
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19147",
"triggerID" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"triggerType" : "PUSH"
}, {
"hash" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369",
"triggerID" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 984d9668ebb8f05c44ed00e4e70fe89205de1c94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864129076
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19147",
"triggerID" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"triggerType" : "PUSH"
}, {
"hash" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369",
"triggerID" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"triggerType" : "PUSH"
}, {
"hash" : "c25b08e49d9604f5316a599704dba02cd2fa2649",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32353",
"triggerID" : "c25b08e49d9604f5316a599704dba02cd2fa2649",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c25b08e49d9604f5316a599704dba02cd2fa2649 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32353)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864129076
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19147",
"triggerID" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"triggerType" : "PUSH"
}, {
"hash" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19147)
* 984d9668ebb8f05c44ed00e4e70fe89205de1c94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864129076
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19147",
"triggerID" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"triggerType" : "PUSH"
}, {
"hash" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369",
"triggerID" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"triggerType" : "PUSH"
}, {
"hash" : "c25b08e49d9604f5316a599704dba02cd2fa2649",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32353",
"triggerID" : "c25b08e49d9604f5316a599704dba02cd2fa2649",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 984d9668ebb8f05c44ed00e4e70fe89205de1c94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369)
* c25b08e49d9604f5316a599704dba02cd2fa2649 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32353)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864117721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864129076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16205: [FLINK-18464][Runtime] fix the bug voidnamespace cast to timewindow
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16205:
URL: https://github.com/apache/flink/pull/16205#issuecomment-864129076
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19147",
"triggerID" : "6085b34b132a9fc6ea7352f8ea911bf8fe8ae4d3",
"triggerType" : "PUSH"
}, {
"hash" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369",
"triggerID" : "984d9668ebb8f05c44ed00e4e70fe89205de1c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 984d9668ebb8f05c44ed00e4e70fe89205de1c94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19369)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org