You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2017/09/20 07:17:07 UTC
commons-collections git commit: COLLECTIONS-658: Add
Automatic-Module-Name MANIFEST entry for Java 9 compatibility.
Repository: commons-collections
Updated Branches:
refs/heads/master d95543d81 -> 80ec288ee
COLLECTIONS-658: Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility.
Project: http://git-wip-us.apache.org/repos/asf/commons-collections/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-collections/commit/80ec288e
Tree: http://git-wip-us.apache.org/repos/asf/commons-collections/tree/80ec288e
Diff: http://git-wip-us.apache.org/repos/asf/commons-collections/diff/80ec288e
Branch: refs/heads/master
Commit: 80ec288ee76bc278d70aa234cbea407a2c9e82a2
Parents: d95543d
Author: Benedikt Ritter <br...@apache.org>
Authored: Wed Sep 20 09:16:53 2017 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Wed Sep 20 09:16:53 2017 +0200
----------------------------------------------------------------------
pom.xml | 19 +++++++++++++++++++
src/changes/changes.xml | 3 +++
2 files changed, 22 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-collections/blob/80ec288e/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index d98ad2d..d122e56 100644
--- a/pom.xml
+++ b/pom.xml
@@ -570,6 +570,25 @@
</ignorePathsToDelete>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>test-jar</goal>
+ </goals>
+ </execution>
+ </executions>
+ <!-- Temporary fix for COLLECTIONS-658, remove this after this has implemented in parent pom -->
+ <configuration>
+ <archive combine.children="append">
+ <manifestEntries>
+ <Automatic-Module-Name>org.apache.commons.collections4</Automatic-Module-Name>
+ </manifestEntries>
+ </archive>
+ </configuration>
+ </plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/commons-collections/blob/80ec288e/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index efc7a9b..c355be7 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -21,6 +21,9 @@
</properties>
<body>
<release version="4.2" date="YYYY-MM-DD" description="New features">
+ <action issue="COLLECTIONS-658" dev="britter" type="add">
+ Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
+ </action>
<action issue="COLLECTIONS-656" dev="ggregory" type="fix">
Fix site build on Java 8
</action>
Re: commons-collections git commit: COLLECTIONS-658: Add
Automatic-Module-Name MANIFEST entry for Java 9 compatibility.
Posted by Benedikt Ritter <br...@apache.org>.
> Am 20.09.2017 um 15:33 schrieb Gary Gregory <ga...@gmail.com>:
>
> Why not do this in the parent POM and release it then? ;-)
See the other thread. We can not do this for all components since we need to review on a per component basis whether the component is ready to be released as Java 9 module.
Cheers,
Benedikt
>
> Gary
>
> On Wed, Sep 20, 2017 at 1:17 AM, <br...@apache.org> wrote:
>
>> Repository: commons-collections
>> Updated Branches:
>> refs/heads/master d95543d81 -> 80ec288ee
>>
>>
>> COLLECTIONS-658: Add Automatic-Module-Name MANIFEST entry for Java 9
>> compatibility.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-collections/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-collections/
>> commit/80ec288e
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-collections/
>> tree/80ec288e
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-collections/
>> diff/80ec288e
>>
>> Branch: refs/heads/master
>> Commit: 80ec288ee76bc278d70aa234cbea407a2c9e82a2
>> Parents: d95543d
>> Author: Benedikt Ritter <br...@apache.org>
>> Authored: Wed Sep 20 09:16:53 2017 +0200
>> Committer: Benedikt Ritter <br...@apache.org>
>> Committed: Wed Sep 20 09:16:53 2017 +0200
>>
>> ----------------------------------------------------------------------
>> pom.xml | 19 +++++++++++++++++++
>> src/changes/changes.xml | 3 +++
>> 2 files changed, 22 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-collections/
>> blob/80ec288e/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/pom.xml b/pom.xml
>> index d98ad2d..d122e56 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -570,6 +570,25 @@
>> </ignorePathsToDelete>
>> </configuration>
>> </plugin>
>> + <plugin>
>> + <groupId>org.apache.maven.plugins</groupId>
>> + <artifactId>maven-jar-plugin</artifactId>
>> + <executions>
>> + <execution>
>> + <goals>
>> + <goal>test-jar</goal>
>> + </goals>
>> + </execution>
>> + </executions>
>> + <!-- Temporary fix for COLLECTIONS-658, remove this after this
>> has implemented in parent pom -->
>> + <configuration>
>> + <archive combine.children="append">
>> + <manifestEntries>
>> + <Automatic-Module-Name>org.apache.commons.collections4</
>> Automatic-Module-Name>
>> + </manifestEntries>
>> + </archive>
>> + </configuration>
>> + </plugin>
>> </plugins>
>> </build>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-collections/
>> blob/80ec288e/src/changes/changes.xml
>> ----------------------------------------------------------------------
>> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
>> index efc7a9b..c355be7 100644
>> --- a/src/changes/changes.xml
>> +++ b/src/changes/changes.xml
>> @@ -21,6 +21,9 @@
>> </properties>
>> <body>
>> <release version="4.2" date="YYYY-MM-DD" description="New features">
>> + <action issue="COLLECTIONS-658" dev="britter" type="add">
>> + Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
>> + </action>
>> <action issue="COLLECTIONS-656" dev="ggregory" type="fix">
>> Fix site build on Java 8
>> </action>
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: commons-collections git commit: COLLECTIONS-658: Add
Automatic-Module-Name MANIFEST entry for Java 9 compatibility.
Posted by Gary Gregory <ga...@gmail.com>.
Why not do this in the parent POM and release it then? ;-)
Gary
On Wed, Sep 20, 2017 at 1:17 AM, <br...@apache.org> wrote:
> Repository: commons-collections
> Updated Branches:
> refs/heads/master d95543d81 -> 80ec288ee
>
>
> COLLECTIONS-658: Add Automatic-Module-Name MANIFEST entry for Java 9
> compatibility.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-collections/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-collections/
> commit/80ec288e
> Tree: http://git-wip-us.apache.org/repos/asf/commons-collections/
> tree/80ec288e
> Diff: http://git-wip-us.apache.org/repos/asf/commons-collections/
> diff/80ec288e
>
> Branch: refs/heads/master
> Commit: 80ec288ee76bc278d70aa234cbea407a2c9e82a2
> Parents: d95543d
> Author: Benedikt Ritter <br...@apache.org>
> Authored: Wed Sep 20 09:16:53 2017 +0200
> Committer: Benedikt Ritter <br...@apache.org>
> Committed: Wed Sep 20 09:16:53 2017 +0200
>
> ----------------------------------------------------------------------
> pom.xml | 19 +++++++++++++++++++
> src/changes/changes.xml | 3 +++
> 2 files changed, 22 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/commons-collections/
> blob/80ec288e/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index d98ad2d..d122e56 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -570,6 +570,25 @@
> </ignorePathsToDelete>
> </configuration>
> </plugin>
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-jar-plugin</artifactId>
> + <executions>
> + <execution>
> + <goals>
> + <goal>test-jar</goal>
> + </goals>
> + </execution>
> + </executions>
> + <!-- Temporary fix for COLLECTIONS-658, remove this after this
> has implemented in parent pom -->
> + <configuration>
> + <archive combine.children="append">
> + <manifestEntries>
> + <Automatic-Module-Name>org.apache.commons.collections4</
> Automatic-Module-Name>
> + </manifestEntries>
> + </archive>
> + </configuration>
> + </plugin>
> </plugins>
> </build>
>
>
> http://git-wip-us.apache.org/repos/asf/commons-collections/
> blob/80ec288e/src/changes/changes.xml
> ----------------------------------------------------------------------
> diff --git a/src/changes/changes.xml b/src/changes/changes.xml
> index efc7a9b..c355be7 100644
> --- a/src/changes/changes.xml
> +++ b/src/changes/changes.xml
> @@ -21,6 +21,9 @@
> </properties>
> <body>
> <release version="4.2" date="YYYY-MM-DD" description="New features">
> + <action issue="COLLECTIONS-658" dev="britter" type="add">
> + Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
> + </action>
> <action issue="COLLECTIONS-656" dev="ggregory" type="fix">
> Fix site build on Java 8
> </action>
>
>