Re: [PR] [GLUTEN-8557][CH] Collapse nested function calls for `And`/`Or` for performance optimization [incubator-gluten]

["KevinyhZou (via GitHub)" <gi...@apache.org>]

KevinyhZou commented on code in PR #8558:
URL: https://github.com/apache/incubator-gluten/pull/8558#discussion_r1966981760


##########
shims/common/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -685,6 +685,13 @@ object GlutenConfig {
     .stringConf
     .createWithDefault("")
 
+  val GLUTEN_SUPPORTED_COLLAPSED_FUNCTIONS =
+    buildConf("spark.gluten.sql.supported.collapseNestedFunctions")
+      .internal()
+      .doc("Collapse nested functions as one for optimization.")
+      .stringConf
+      .createWithDefault("and,or");

Review Comment:
   Not found unsuitable case for the ci testing. But I'm afraid there maybe some unsuitable case in our online sqls, which the ci testing do not cover，So I think it‘s better to keep them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org