[GitHub] gengliangwang edited a comment on issue #23829: [SPARK-26915][SQL]File source should write without schema validation in DataFrameWriter.save()

[GitBox <gi...@apache.org>]

gengliangwang edited a comment on issue #23829: [SPARK-26915][SQL]File source should write without schema validation in DataFrameWriter.save()
URL: https://github.com/apache/spark/pull/23829#issuecomment-464992003
 
 
   After thoughts, I don't think `DataFrameWriter.save` has to be involved with the `table` concept.  Otherwise,  things can be complex and there can be two different behaviors in one API `DataFrameWriter.save`. 
   
   That is to say,  let's remove the expression `AppendData` and `OverwriteByExpression` in `DataFrameWriter.save`, since their behaviors are different with the API's.
   
   It just doesn’t have to be a table. We can use `AppendData` and `OverwriteByExpression` in `DataFrameWriter.saveAsTable`, which is more appropriate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org