You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Sam Whittle (Jira)" <ji...@apache.org> on 2021/03/12 08:26:00 UTC

[jira] [Updated] (BEAM-11727) Optimize ExecutionStateSampler

     [ https://issues.apache.org/jira/browse/BEAM-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Whittle updated BEAM-11727:
-------------------------------
    Resolution: Fixed
        Status: Resolved  (was: Triage Needed)

> Optimize ExecutionStateSampler
> ------------------------------
>
>                 Key: BEAM-11727
>                 URL: https://issues.apache.org/jira/browse/BEAM-11727
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Sam Whittle
>            Assignee: Sam Whittle
>            Priority: P2
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Showed up as 1.5% of CPU on Nexmark 11 streaming benchmark run.
> It appears to be using a ConcurrentSkipListSet and most of the cpu is relatedd to inserts/removes in that, involving the system hash of the entries as that is used for ordering.
> The consistent ordering is unnecessary. Additionally for other reasons, removal and iteration is already synchronized and so performance will likely be better just using a synchronized HashMap and synchronizing in the add case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)