You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2015/01/27 15:04:37 UTC

[jclouds] JCLOUDS-813: fix list private images (#653)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/653

-- Commit Summary --

  * JCLOUDS-813: fix list private images

-- File Changes --

    M providers/softlayer/src/main/java/org/jclouds/softlayer/compute/strategy/SoftLayerComputeServiceAdapter.java (1)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/653.patch
https://github.com/jclouds/jclouds/pull/653.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/653

Re: [jclouds] JCLOUDS-813: fix list private images (#653)

Posted by Andrea Turli <no...@github.com>.

Closed #653.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/653#event-226188226

Re: [jclouds] JCLOUDS-813: fix list private images (#653)

Posted by Andrea Turli <no...@github.com>.

@nacx Some users get a NPE when `listImages` is called.
This is happening [here](https://github.com/andreaturli/jclouds/blob/fix/softlayer-list-private-images/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/OperatingSystem.java#L107). Debugging a little bit, I found out the reason: for some private images of an account [here](https://github.com/andreaturli/jclouds/blob/fix/softlayer-list-private-images/providers/softlayer/src/main/java/org/jclouds/softlayer/compute/strategy/SoftLayerComputeServiceAdapter.java#L290-L296) jclouds can't find the globalIdentifier of an image. 
I think we should simply ignore those kind of images as they are broken (not well configured by the user in SL)

This patch is an attempt to protect jclouds by these manual mistakes.

 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/653#issuecomment-71819478

Re: [jclouds] JCLOUDS-813: fix list private images (#653)

Posted by Andrea Turli <no...@github.com>.

@nacx does it look good?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/653#issuecomment-71675280