[PR] Fixed: cleanAll deletes the version-controlled package-lock.json files (OFBIZ-13695) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak opened a new pull request, #2343:
URL: https://github.com/apache/ofbiz-framework/pull/2343

   cleanAll and rest-api's cleanDocAssets depended on cleanNpmInstall, the Gradle clean<TaskName> rule for npmInstall, which deletes every output of the task, including package-lock.json. Running cleanAll therefore removed the committed lockfiles and npm re-resolved all dependencies from scratch, which currently breaks npmInstall on release24.09 (npm 10.8.2 fails with "Cannot read properties of null (reading 'edgesOut')"). cleanNpm is now a Delete task that removes only node_modules, and it replaces cleanNpmInstall in both places.
   
   Thanks: Anahita Goljahani for reporting the issue during the 24.09.08 release vote


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: cleanAll deletes the version-controlled package-lock.json files (OFBIZ-13695) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak merged PR #2343:
URL: https://github.com/apache/ofbiz-framework/pull/2343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org