You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/06/01 13:38:11 UTC
(datafusion) branch gh-readonly-queue/main/pr-22284-6644732a8a7a4f3cf8574198015f0ef852d34276 created (now f338f198a9)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-22284-6644732a8a7a4f3cf8574198015f0ef852d34276
in repository https://gitbox.apache.org/repos/asf/datafusion.git
at f338f198a9 test: cover regexp_like multiline flag (#22284)
This branch includes the following new commits:
new f338f198a9 test: cover regexp_like multiline flag (#22284)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
(datafusion) 01/01: test: cover regexp_like multiline flag (#22284)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-22284-6644732a8a7a4f3cf8574198015f0ef852d34276
in repository https://gitbox.apache.org/repos/asf/datafusion.git
commit f338f198a98beeeaf58c8b29a2943babcb061f91
Author: nanookclaw <na...@agentmail.to>
AuthorDate: Mon Jun 1 13:37:59 2026 +0000
test: cover regexp_like multiline flag (#22284)
## Which issue does this PR close?
- Relates to #22268.
## Rationale for this change
The issue documents a PostgreSQL compatibility expectation for
`regexp_like(E'a\nb', '^b', 'm')`: with the multiline flag, `^` should
match after a newline. Current `main` already returns the expected
result for the reported SQL, so this PR adds focused regression coverage
to keep that behavior from drifting.
## What changes are included in this PR?
This adds `regexp_like` tests for the multiline `m` flag in the SQL
logic test suite and in the Rust unit tests for the scalar,
array/scalar, and array/array execution paths. The adjacent no-flags SQL
case remains false, documenting that the new behavior is specifically
tied to `m`.
## Are these changes tested?
Yes:
- `cargo fmt --all --check`
- `git diff --check`
- `cargo test -p datafusion-functions --lib regexp_like`
- `cargo test -p datafusion-sqllogictest --test sqllogictests --
regexp_like`
## Are there any user-facing changes?
No. This is regression coverage for existing behavior.
---------
Co-authored-by: Nanook <na...@users.noreply.github.com>
---
datafusion/sqllogictest/test_files/regexp/regexp_like.slt | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/datafusion/sqllogictest/test_files/regexp/regexp_like.slt b/datafusion/sqllogictest/test_files/regexp/regexp_like.slt
index 22d5066d5f..30fa913896 100644
--- a/datafusion/sqllogictest/test_files/regexp/regexp_like.slt
+++ b/datafusion/sqllogictest/test_files/regexp/regexp_like.slt
@@ -168,6 +168,16 @@ SELECT 'foo\nbar\nbaz' ~ 'bar';
----
true
+query B
+SELECT regexp_like(E'a\nb', '^b', 'm');
+----
+true
+
+query B
+SELECT regexp_like(E'a\nb', '^b');
+----
+false
+
statement error
Error during planning: Cannot infer common argument type for regex operation List(Field { name: "item", data_type: Int64, nullable: true, metadata: {} }) ~ List(Field { name: "item", data_type: Int64, nullable: true, metadata: {} })
select [1,2] ~ [3];
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org