[GitHub] spark pull request #22468: [SPARK-25374][SQL] SafeProjection supports fallba...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22468#discussion_r225520290
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedSafeProjection.scala ---
    @@ -0,0 +1,173 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql.catalyst.expressions
    +
    +import org.apache.spark.SparkException
    +import org.apache.spark.sql.catalyst.InternalRow
    +import org.apache.spark.sql.catalyst.expressions.aggregate.NoOp
    +import org.apache.spark.sql.catalyst.util.{ArrayBasedMapData, ArrayData, GenericArrayData, MapData}
    +import org.apache.spark.sql.types._
    +
    +
    +/**
    + * An interpreted version of a safe projection.
    + *
    + * @param expressions that produces the resulting fields. These expressions must be bound
    + *                    to a schema.
    + */
    +class InterpretedSafeProjection(expressions: Seq[Expression]) extends Projection {
    +
    +  private[this] val mutableRow = new SpecificInternalRow(expressions.map(_.dataType))
    +
    +  private[this] val exprsWithWriters = expressions.zipWithIndex.filter {
    +    case (NoOp, _) => false
    --- End diff --
    
    does `SafeProjection` need to handle `NoOp`? It's only used with `MutableProjection` in aggregate.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org