You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "duan xiong (Jira)" <ji...@apache.org> on 2021/10/20 06:47:00 UTC

[jira] [Commented] (CALCITE-3078) Duplicate code lastDay in calcite-avatica and calcite

    [ https://issues.apache.org/jira/browse/CALCITE-3078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431006#comment-17431006 ] 

duan xiong commented on CALCITE-3078:
-------------------------------------

[~ambition119] If you plan to make the method public in AVATICA. Please add another PR in CALCITE to remove the same method.

> Duplicate code lastDay in calcite-avatica and calcite
> -----------------------------------------------------
>
>                 Key: CALCITE-3078
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3078
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica, core
>    Affects Versions: 1.19.0
>            Reporter: pingle wang
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The code of lastDay appears in calcite( [lastDay|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java#L2322] ), and appears in calcite-avatica. I think the duplicate code can change the calcite-avatica to public function then be used by calcite.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)