You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/25 22:22:48 UTC

[GitHub] [incubator-hudi] vinothchandar opened a new pull request #1446: [MINOR] Add link for yields.io usage

vinothchandar opened a new pull request #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446
 
 
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] lamber-ken commented on issue #1446: [MINOR] Add link for yields.io usage

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446#issuecomment-604169166
 
 
   hi @vinothchandar, it may have been delayed, it worked finally.
   https://travis-ci.org/github/apache/incubator-hudi/builds/667011979

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1446: [MINOR] Add link for yields.io usage

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446#issuecomment-604120086
 
 
   ah.. I was hoping to see the CI build pass. :) its still there after merging.. n p 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1446: [MINOR] Add link for yields.io usage

Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446#issuecomment-604169166
 
 
   hi @vinothchandar, 
   when you submit the pr, the travis build fail. from its stacktrace, we may met some bug
   https://travis-ci.org/github/apache/incubator-hudi/builds/667011488
   
   after merged, it worked finally.
   https://travis-ci.org/github/apache/incubator-hudi/builds/667011979

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] smarthi merged pull request #1446: [MINOR] Add link for yields.io usage

Posted by GitBox <gi...@apache.org>.
smarthi merged pull request #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] lamber-ken commented on issue #1446: [MINOR] Add link for yields.io usage

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446#issuecomment-604243812
 
 
   > @lamber-ken can you please update the README on asf-site with some details on the automation and tips like these.. ? There is a section already.
   
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1446: [MINOR] Add link for yields.io usage

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446#issuecomment-604238808
 
 
   @lamber-ken can you please update the README on asf-site with some details on the automation and tips like these.. ? There is a section already. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] lamber-ken commented on issue #1446: [MINOR] Add link for yields.io usage

Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1446: [MINOR] Add link for yields.io usage
URL: https://github.com/apache/incubator-hudi/pull/1446#issuecomment-604174107
 
 
   btw, if the ci build fail, you can use  following command to trigger rebuild. @vinothchandar 
   ```
   git commit --allow-empty -m 'trigger rebuild' 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services