You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/07/31 18:41:57 UTC
[native-toolchain-CR] Add RapidJson 1.1.0
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11092
Change subject: Add RapidJson 1.1.0
......................................................................
Add RapidJson 1.1.0
Also copy over license to built tarball.
Testing:
Built both rapidjson version locally with:
./build.sh rapidjson 0.11
./build.sh rapidjson 1.1.0
Will run build on a range of operating systems but I don't anticipate
any problems since this "build" is so trivial.
Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
---
M buildall.sh
M source/rapidjson/build.sh
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/92/11092/1
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 18:15:17 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11092
to look at the new patch set (#2).
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
IMPALA-7364: Add RapidJson 1.1.0
Also copy over license to built tarball.
Testing:
Built both rapidjson version locally with:
./build.sh rapidjson 0.11
./build.sh rapidjson 1.1.0
Will run build on a range of operating systems but I don't anticipate
any problems since this "build" is so trivial.
Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
---
M buildall.sh
M source/rapidjson/build.sh
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/92/11092/2
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
IMPALA-7364: Add RapidJson 1.1.0
Also copy over license to built tarball.
Testing:
Built both rapidjson version locally with:
./build.sh rapidjson 0.11
./build.sh rapidjson 1.1.0
Will run build on a range of operating systems but I don't anticipate
any problems since this "build" is so trivial.
Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Reviewed-on: http://gerrit.cloudera.org:8080/11092
Tested-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
---
M buildall.sh
M source/rapidjson/build.sh
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Verified
Bikramjeet Vig: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 3:
I'm generating the artifacts now using an internal job. If it succeeds in a few hours the ID will be 185-ec90313c05
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:22:01 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 3:
It should be uploaded. LMK if you have any issues with it.
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 17:04:14 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add RapidJson 1.1.0
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: Add RapidJson 1.1.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11092/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11092/1//COMMIT_MSG@7
PS1, Line 7: Add RapidJson 1.1.0
> Reference IMPALA-7364?
Done
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 18:14:40 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 3:
Sure. Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 01:35:40 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 1: Verified+1
Was able to confirm this builds ok on all the distros I have access to.
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 18:15:10 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 3:
Thank you, Tim! How can I find the latest build id for native-toolchain?
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 00:54:41 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 3:
It works as expected. Patch ready for review: https://gerrit.cloudera.org/#/c/11124/
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 14:56:46 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-7364: Add RapidJson 1.1.0
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: IMPALA-7364: Add RapidJson 1.1.0
......................................................................
Patch Set 2: Code-Review+2
> Was able to confirm this builds ok on all the distros I have access
> to.
Good enough for me
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Aug 2018 23:43:02 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add RapidJson 1.1.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: Add RapidJson 1.1.0
......................................................................
Patch Set 1:
There're some broken APIs to fix. For example
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc: In member function ‘kudu::Status kudu::JsonReader::Init()’:
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc:40:80: error: no matching function for call to ‘kudu::Status::Corruption(const char [21], rapidjson::ParseErrorCode)’
return Status::Corruption("JSON text is corrupt", document_.GetParseError());
^
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc:40:80: note: candidate is:
In file included from /mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.h:27:0,
from /mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc:18:
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/status.h:228:17: note: static kudu::Status kudu::Status::Corruption(const kudu::Slice&, const kudu::Slice&, int16_t)
static Status Corruption(const Slice& msg, const Slice& msg2 = Slice(),
^
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/status.h:228:17: note: no known conversion for argument 2 from ‘rapidjson::ParseErrorCode’ to ‘const kudu::Slice&’
make[3]: *** [be/src/kudu/util/CMakeFiles/kudu_util.dir/jsonreader.cc.o] Error 1
make[2]: *** [be/src/kudu/util/CMakeFiles/kudu_util.dir/all] Error 2
make[1]: *** [be/src/service/CMakeFiles/impalad.dir/rule] Error 2
make: *** [impalad] Error 2
I think I can help on this if they're not too much.
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 01:14:57 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add RapidJson 1.1.0
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11092 )
Change subject: Add RapidJson 1.1.0
......................................................................
Patch Set 1:
(1 comment)
Thanks for this. I can build on ubuntu14.04. Will test building impala on it.
http://gerrit.cloudera.org:8080/#/c/11092/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11092/1//COMMIT_MSG@7
PS1, Line 7: Add RapidJson 1.1.0
Reference IMPALA-7364?
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 00:59:36 +0000
Gerrit-HasComments: Yes