You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/04/30 23:31:26 UTC
[kudu-CR] Deflake TestTimeouts.testLowTimeouts
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13202
Change subject: Deflake TestTimeouts.testLowTimeouts
......................................................................
Deflake TestTimeouts.testLowTimeouts
It turns out that if a ConnectToCluster "RPC" results in an RPC to each
master and each of those RPCs times out, the ConnectToCluster RPC ends
up with a ServiceUnavailable status, not a TimedOut status. This updates
the test to reflect this.
Before this patch, I saw 58/200 failures; after it I saw zero. The
58/200 seems big compared to the frequency of this in precommits, etc,
but anyway this fix ought to help regardless of how frequent the
problem is.
Change-Id: I7d1a429fe5749c31495e0d10f74a0cfb1e623310
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/13202/1
--
To view, visit http://gerrit.cloudera.org:8080/13202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d1a429fe5749c31495e0d10f74a0cfb1e623310
Gerrit-Change-Number: 13202
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Deflake TestTimeouts.testLowTimeouts
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13202 )
Change subject: Deflake TestTimeouts.testLowTimeouts
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java:
http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@44
PS1, Line 44: * TODO(aserbin) this test is flaky; add delays on the server side to make it stable
> Remove this?
+1
http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@59
PS1, Line 59: // in the case where there is a master election).
nit: add 'The latter captures ServiceUnavailable status from master.'
--
To view, visit http://gerrit.cloudera.org:8080/13202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d1a429fe5749c31495e0d10f74a0cfb1e623310
Gerrit-Change-Number: 13202
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 May 2019 18:07:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] Deflake TestTimeouts.testLowTimeouts
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13202 )
Change subject: Deflake TestTimeouts.testLowTimeouts
......................................................................
Deflake TestTimeouts.testLowTimeouts
It turns out that if a ConnectToCluster "RPC" results in an RPC to each
master and each of those RPCs times out, the ConnectToCluster RPC ends
up with a ServiceUnavailable status, not a TimedOut status. This updates
the test to reflect this.
Before this patch, I saw 58/200 failures; after it I saw zero. The
58/200 seems big compared to the frequency of this in precommits, etc,
but anyway this fix ought to help regardless of how frequent the
problem is.
Change-Id: I7d1a429fe5749c31495e0d10f74a0cfb1e623310
Reviewed-on: http://gerrit.cloudera.org:8080/13202
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/13202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d1a429fe5749c31495e0d10f74a0cfb1e623310
Gerrit-Change-Number: 13202
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Deflake TestTimeouts.testLowTimeouts
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13202 )
Change subject: Deflake TestTimeouts.testLowTimeouts
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java:
http://gerrit.cloudera.org:8080/#/c/13202/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@44
PS1, Line 44: * TODO(aserbin) this test is flaky; add delays on the server side to make it stable
Remove this?
--
To view, visit http://gerrit.cloudera.org:8080/13202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d1a429fe5749c31495e0d10f74a0cfb1e623310
Gerrit-Change-Number: 13202
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Apr 2019 23:48:54 +0000
Gerrit-HasComments: Yes