You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/19 08:26:25 UTC
[GitHub] [doris] 924060929 commented on a diff in pull request #13416: [Feature](Nereids) Support materialized index selection.
924060929 commented on code in PR #13416:
URL: https://github.com/apache/doris/pull/13416#discussion_r999072231
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/mv/SelectMaterializedIndexWithAggregate.java:
##########
@@ -543,7 +398,7 @@ public CheckContext(LogicalOlapScan scan) {
)
));
Review Comment:
```java
Map<Boolean, Map<String, Column>> nameToColumnGroupingByIsKey
= scan.getTable().getSchemaByIndexId(indexId)
.collect(Collectors.groupingBy(
Column::isKey,
Collectors.toMap(Column::getName, Function.identity())
));
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -313,22 +312,13 @@ public PlanFragment visitPhysicalOlapScan(PhysicalOlapScan olapScan, PlanTransla
tupleDescriptor.setRef(tableRef);
olapScanNode.setSelectedPartitionIds(olapScan.getSelectedPartitionIds());
Review Comment:
olapScanNode should be immutable?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/mv/SelectMaterializedIndexWithAggregate.java:
##########
@@ -543,7 +398,7 @@ public CheckContext(LogicalOlapScan scan) {
)
));
Review Comment:
rename `checkHasNoValueTypeColumn` method to `disablePreAggIfContainsAnyValueColumn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org