You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pedro-martins <gi...@git.apache.org> on 2015/09/19 22:26:24 UTC
[GitHub] cloudstack pull request: Removed the empty class 'com.cloud.deploy...
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/856
Removed the empty class 'com.cloud.deploy.PlannerBase'
Removed the PlannerBase class because it is does not bring contribution to ACS' code.
We changed com.cloud.deploy.FirstFitPlanner, now it doesn’t extends the PlannerBase and implements the com.cloud.deploy.DeploymentPlanner.
We also removed the method com.cloud.deploy.DeploymentPlanner.check(VirtualMachineProfile, DeploymentPlan, DeployDestination, ExcludeList) that was not used anywhere.
Additionally, we removed the “_” from FirstFitPlanner's attributes name, in order to have them in a more standard way.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack master-lrg-cs-hackday-004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #856
----
commit d5a22526f1fe895d641d13ff0dea8505e2d949a2
Author: pedro-martins <ph...@gmail.com>
Date: 2015-09-19T20:10:21Z
Removed class com.cloud.deploy.PlannerBase
removed method
com.cloud.deploy.DeploymentPlanner.check(VirtualMachineProfile,
DeploymentPlan, DeployDestination, ExcludeList)
modified the com.cloud.deploy.FirstFitPlanner for extends AdapterBase
and implements DeploymentPlanner
removed "_" from variables name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed the empty class 'com.cloud.deploy...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/856#issuecomment-141712362
@pedro-martins that is good that you removed and unused method in com.cloud.deploy.DeploymentPlanner, however you forgot to remove all of the implementations of classes that implement it.
BareMetalPlanner is one of the classes that you forgot to fix, there are others
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed the empty class 'com.cloud.deploy...
Posted by pedro-martins <gi...@git.apache.org>.
Github user pedro-martins closed the pull request at:
https://github.com/apache/cloudstack/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed the empty class 'com.cloud.deploy...
Posted by pedro-martins <gi...@git.apache.org>.
GitHub user pedro-martins reopened a pull request:
https://github.com/apache/cloudstack/pull/856
Removed the empty class 'com.cloud.deploy.PlannerBase'
Removed the PlannerBase class because it is does not bring contribution to ACS' code.
We changed com.cloud.deploy.FirstFitPlanner, now it doesn’t extends the PlannerBase and implements the com.cloud.deploy.DeploymentPlanner.
We also removed the method com.cloud.deploy.DeploymentPlanner.check(VirtualMachineProfile, DeploymentPlan, DeployDestination, ExcludeList) that was not used anywhere.
Additionally, we removed the “_” from FirstFitPlanner's attributes name, in order to have them in a more standard way.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack master-lrg-cs-hackday-004
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #856
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed the empty class 'com.cloud.deploy...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed the empty class 'com.cloud.deploy...
Posted by pedro-martins <gi...@git.apache.org>.
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/856#issuecomment-142042882
Reopening PR that was closed by mistake
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---