You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Anil K Patel (JIRA)" <ji...@apache.org> on 2007/02/20 05:10:06 UTC
[jira] Created: (OFBIZ-739) Return a Part Issued to FixedAssetMaint
Return a Part Issued to FixedAssetMaint
---------------------------------------
Key: OFBIZ-739
URL: https://issues.apache.org/jira/browse/OFBIZ-739
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Reporter: Anil K Patel
Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (OFBIZ-739) Return a Part Issued to FixedAssetMaint
Posted by Scott Gray <le...@gmail.com>.
Please post your questions to the user list and do not cross post
Thanks
Scott
shruthi krishnan wrote:
> how to search using delegators with a non key attribute?how does it
> return
> the result?
>
>
> On 2/22/07, Scott Gray (JIRA) <ji...@apache.org> wrote:
>>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>>
>> Scott Gray updated OFBIZ-739:
>> -----------------------------
>>
>> Attachment: ReturnPartIssuedToFixedAssetMaint.patch
>>
>> Hi Anil
>>
>> This is taking longer than I expected and I won't be finished
>> tonight, I'm
>> attaching a new patch in case you want to do some more work, here's what
>> I've changed so far:
>> 1. Changed all occurances of issuence to issuance
>> 2. Added missing PageTitleAddItemIssuance uiLabel
>> 3. Updated main-decorator to use layoutSettings for javascripts and
>> removed reference to tabstyles.css
>> 4. Removed hidden primaryProductCategoryId from the assetmaint
>> lookupProduct form, it was blocking the noConditionFind field
>> 5. Fixed friendly error message code in addPartFixedAssetMaint service,
>> getMessage requires a map not a list
>>
>> The next thing I was going to look at is why the Parts List table has no
>> borders
>>
>> Regards
>> Scott
>>
>> > Return a Part Issued to FixedAssetMaint
>> > ---------------------------------------
>> >
>> > Key: OFBIZ-739
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-739
>> > Project: OFBiz (The Open for Business Project)
>> > Issue Type: Improvement
>> > Reporter: Anil K Patel
>> > Assigned To: Scott Gray
>> > Attachments: ReturnPartIssuedToFixedAssetMaint.patch,
>> ReturnPartIssuedToFixedAssetMaint.patch,
>> ReturnPartIssuedToFixedAssetMaint.patch
>> >
>> >
>> > Add option for user to be able to return a part that is issued to a
>> fixedAssetMaint.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Re: [jira] Updated: (OFBIZ-739) Return a Part Issued to FixedAssetMaint
Posted by shruthi krishnan <nk...@gmail.com>.
how to search using delegators with a non key attribute?how does it return
the result?
On 2/22/07, Scott Gray (JIRA) <ji...@apache.org> wrote:
>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Scott Gray updated OFBIZ-739:
> -----------------------------
>
> Attachment: ReturnPartIssuedToFixedAssetMaint.patch
>
> Hi Anil
>
> This is taking longer than I expected and I won't be finished tonight, I'm
> attaching a new patch in case you want to do some more work, here's what
> I've changed so far:
> 1. Changed all occurances of issuence to issuance
> 2. Added missing PageTitleAddItemIssuance uiLabel
> 3. Updated main-decorator to use layoutSettings for javascripts and
> removed reference to tabstyles.css
> 4. Removed hidden primaryProductCategoryId from the assetmaint
> lookupProduct form, it was blocking the noConditionFind field
> 5. Fixed friendly error message code in addPartFixedAssetMaint service,
> getMessage requires a map not a list
>
> The next thing I was going to look at is why the Parts List table has no
> borders
>
> Regards
> Scott
>
> > Return a Part Issued to FixedAssetMaint
> > ---------------------------------------
> >
> > Key: OFBIZ-739
> > URL: https://issues.apache.org/jira/browse/OFBIZ-739
> > Project: OFBiz (The Open for Business Project)
> > Issue Type: Improvement
> > Reporter: Anil K Patel
> > Assigned To: Scott Gray
> > Attachments: ReturnPartIssuedToFixedAssetMaint.patch,
> ReturnPartIssuedToFixedAssetMaint.patch,
> ReturnPartIssuedToFixedAssetMaint.patch
> >
> >
> > Add option for user to be able to return a part that is issued to a
> fixedAssetMaint.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Assigned: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Gray reassigned OFBIZ-739:
--------------------------------
Assignee: Scott Gray
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Assigned To: Scott Gray
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474811 ]
Scott Gray commented on OFBIZ-739:
----------------------------------
Hi Anil
I have been reviewing the patch, but I won't have time to look at it more until tonight (morning here now). If someone else wants to review and commit that's fine by me.
My only comment on review at this stage is that it seemed funny that you can partially issue parts but you can't partially return parts from issue.
Regards
Scott
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-739) Return a Part Issued to FixedAssetMaint
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anil K Patel updated OFBIZ-739:
-------------------------------
Attachment: ReturnPartIssuedToFixedAssetMaint.patch
Added a Service to handle part Issuance in user friendly manner if the productId is not correct or if there is not enough in stock.
Added a service to return a part that has been issued to a FixedAssetMaint.
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474839 ]
Anil K Patel commented on OFBIZ-739:
------------------------------------
Scott,
If I understand your comments right, E.g If user wanted 10pcs of a Product. If in Stock we have enough available quantity but its on separate InventoryItems then We loop through the Inventory Items and create ItemIssuances till required number is issued. In this case multiple ItemIssances will be created.
When doing returns, user will have to return Individual ItemIssuance. This turns out to be a Simple Implementation, As long a its not Breaking any Business Rule, I think this behavior is acceptable.
Did this answer your comments or am I way off.
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-739) Return a Part Issued to FixedAssetMaint
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Gray closed OFBIZ-739.
----------------------------
Resolution: Fixed
Thanks Anil, your patch (with changes) was committed in rev. 510920
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Assigned To: Scott Gray
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-739) Return a Part Issued to FixedAssetMaint
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Gray updated OFBIZ-739:
-----------------------------
Attachment: ReturnPartIssuedToFixedAssetMaint.patch
Hi Anil
This is taking longer than I expected and I won't be finished tonight, I'm attaching a new patch in case you want to do some more work, here's what I've changed so far:
1. Changed all occurances of issuence to issuance
2. Added missing PageTitleAddItemIssuance uiLabel
3. Updated main-decorator to use layoutSettings for javascripts and removed reference to tabstyles.css
4. Removed hidden primaryProductCategoryId from the assetmaint lookupProduct form, it was blocking the noConditionFind field
5. Fixed friendly error message code in addPartFixedAssetMaint service, getMessage requires a map not a list
The next thing I was going to look at is why the Parts List table has no borders
Regards
Scott
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Assigned To: Scott Gray
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-739) Return a Part Issued to FixedAssetMaint
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anil K Patel updated OFBIZ-739:
-------------------------------
Attachment: ReturnPartIssuedToFixedAssetMaint.patch
Scott, Thanks for looking at the patch. I have fixed issues listed by you. I hope now this is fine. Regards
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475082 ]
Anil K Patel commented on OFBIZ-739:
------------------------------------
Scott,
Sorry for posting so bad code. I try to do good Job, This time I think I got in too much hurry. A Good lesson learned. Thanks for your time.
Regards
Anil
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Assigned To: Scott Gray
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474782 ]
Anil K Patel commented on OFBIZ-739:
------------------------------------
Can somebody review this patch and if possible commit it. I have Printing of Maintenance implemented, I am waiting on this patch to be applied so I can prepare other patch and post it.
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475269 ]
Scott Gray commented on OFBIZ-739:
----------------------------------
Hi Anil
No big deal, not all of those problems are related to this patch, they're just things I came across while trying to test it.
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Assigned To: Scott Gray
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474365 ]
Scott Gray commented on OFBIZ-739:
----------------------------------
Hi Anil
Just a quick review for now:
1. Could you please change the license headers to the new version, you can find them in APACHE2_HEADERS in the root directory.
2. I think I spotted a bad map name in the return issuance service, one of the set operations is using "v" instead of what the others are using.
Thanks
Scott
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-739) Return a Part Issued to
FixedAssetMaint
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474848 ]
Scott Gray commented on OFBIZ-739:
----------------------------------
I'll have to have another look tonight, but yes I think that explains what I was looking at. I asked because I noticed that the service for issuing parts takes quantity as a parameter whereas the service for returning doesn't.
I still don't have a full picture because I haven't looked at all of the code yet but I'll get it all done tonight.
Thanks
Scott
> Return a Part Issued to FixedAssetMaint
> ---------------------------------------
>
> Key: OFBIZ-739
> URL: https://issues.apache.org/jira/browse/OFBIZ-739
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Reporter: Anil K Patel
> Attachments: ReturnPartIssuedToFixedAssetMaint.patch, ReturnPartIssuedToFixedAssetMaint.patch
>
>
> Add option for user to be able to return a part that is issued to a fixedAssetMaint.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.