You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by ng...@apache.org on 2008/05/20 15:23:06 UTC

svn commit: r658238 - /mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpHandler.java

Author: ngn
Date: Tue May 20 06:23:06 2008
New Revision: 658238

URL: http://svn.apache.org/viewvc?rev=658238&view=rev
Log:
Fixing issue where Ftplet.onConnect and onDisconnect are not called correctly (FTPSERVER-135)

Modified:
    mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpHandler.java

Modified: mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpHandler.java
URL: http://svn.apache.org/viewvc/mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpHandler.java?rev=658238&r1=658237&r2=658238&view=diff
==============================================================================
--- mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpHandler.java (original)
+++ mina/ftpserver/trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpHandler.java Tue May 20 06:23:06 2008
@@ -57,7 +57,12 @@
     }
 
     public void sessionClosed(FtpIoSession session) throws Exception {
-    	context.getFtpletContainer().onDisconnect(session.getFtpletSession());
+        try {
+            context.getFtpletContainer().onDisconnect(session.getFtpletSession());
+        } catch(Exception e) {
+            // shallow the exception, we're closing down the session anyways
+            LOG.warn("Ftplet threw an exception on disconnect", e);
+        }
         
         ServerFtpStatistics stats = ((ServerFtpStatistics)context.getFtpStatistics());