You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:21:17 UTC

[GitHub] [systemml] Baunsgaard opened a new pull request #970: M fed stat

Baunsgaard opened a new pull request #970:
URL: https://github.com/apache/systemml/pull/970


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemml] sebwrede commented on pull request #970: [MINOR] Add federated Prefix for statistics

Posted by GitBox <gi...@apache.org>.
sebwrede commented on pull request #970:
URL: https://github.com/apache/systemml/pull/970#issuecomment-644606246


   LGTM.
   Why is  `-Dlog4j.configuration=file:` removed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemml] asfgit closed pull request #970: [MINOR] Add federated Prefix for statistics

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #970:
URL: https://github.com/apache/systemml/pull/970


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemml] Baunsgaard commented on pull request #970: [MINOR] Add federated Prefix for statistics

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #970:
URL: https://github.com/apache/systemml/pull/970#issuecomment-644616788


   @sebwrede, Thanks i forgot about this PR, I will merge it soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemml] Baunsgaard commented on pull request #970: [MINOR] Add federated Prefix for statistics

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #970:
URL: https://github.com/apache/systemml/pull/970#issuecomment-644616064


   Because previously it required the whole line for the logging file. but now it has been changed to construct the `-Dlog4j.configuration=file:` part inside a variable. If you compare to line 303, you can see the distributed does it the same way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [systemml] Baunsgaard commented on pull request #970: [MINOR] Add federated Prefix for statistics

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #970:
URL: https://github.com/apache/systemml/pull/970#issuecomment-641335897


   Note, two minor fixes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org