You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2014/07/16 05:12:55 UTC

[14/14] git commit: TS-1475: Coverity 1196454 - fix resource leak

TS-1475: Coverity 1196454 - fix resource leak


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a890d312
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a890d312
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a890d312

Branch: refs/heads/master
Commit: a890d31215a4ce00b51f9d9845207de27e8ab957
Parents: 141b122
Author: JvD <ja...@cable.comcast.com>
Authored: Tue Jul 15 15:03:28 2014 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Jul 15 21:11:38 2014 -0600

----------------------------------------------------------------------
 plugins/experimental/buffer_upload/buffer_upload.cc | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a890d312/plugins/experimental/buffer_upload/buffer_upload.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/buffer_upload/buffer_upload.cc b/plugins/experimental/buffer_upload/buffer_upload.cc
index 11d1f56..df0f3d8 100644
--- a/plugins/experimental/buffer_upload/buffer_upload.cc
+++ b/plugins/experimental/buffer_upload/buffer_upload.cc
@@ -951,11 +951,14 @@ create_directory()
       }
     }
     dir = opendir(".");
+    if (dir == NULL) 
+      goto error_out;
     while ((d = readdir(dir))) {
       remove(d->d_name);
     }
     if (chdir("..") == -1) return 0;
   }
+  closedir(dir);
 
   if (chdir(cwd) == -1) return 0;
   return 1;