You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2026/06/06 01:41:52 UTC

[PR] jax_fingerprint: Emit type-default for custom log fields with no transaction [trafficserver]

maskit opened a new pull request, #13243:
URL: https://github.com/apache/trafficserver/pull/13243

   When a log entry has no backing HttpSM (e.g. a malformed H2/H3 request rejected before transaction creation), passing nullptr to a TSLogFieldRegister'd callback dereferences null inside the plugin.  Skip the callback in that case and emit the type-appropriate default the way built-in fields do: 0 for ints, "-" for strings, AF_UNSPEC for IPs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] jax_fingerprint: Emit type-default for custom log fields with no transaction [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #13243:
URL: https://github.com/apache/trafficserver/pull/13243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] jax_fingerprint: Emit type-default for custom log fields with no transaction [trafficserver]

Posted by "amirnoshian (via GitHub)" <gi...@apache.org>.
amirnoshian commented on PR #13243:
URL: https://github.com/apache/trafficserver/pull/13243#issuecomment-4648841451

   thanks for your feedback now i make the new issue do you have idea for
   thats problem ?
   
   On Mon, Jun 8, 2026 at 3:19 PM JosiahWI ***@***.***> wrote:
   
   > *JosiahWI* left a comment (apache/trafficserver#13243)
   > <https://github.com/apache/trafficserver/pull/13243#issuecomment-4648673684>
   >
   > @amirnoshian <https://github.com/amirnoshian> If you could open an issue
   > that would help us track it. This is not the right thread for your comment.
   > Please ask if you would like help opening an issue or have questions about
   > it.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/trafficserver/pull/13243?email_source=notifications&email_token=AW2PJBZYLRFCSWWWNYZBSTD462R5DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUHA3DOMZWHA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4648673684>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AW2PJBYA3QVBXUG3QNTIEAD462R5DAVCNFSM6AAAAACZ4U4G3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMNBYGY3TGNRYGQ>
   > .
   > Triage notifications, keep track of coding agent tasks and review pull
   > requests on the go with GitHub Mobile for iOS
   > <https://github.com/notifications/mobile/ios/AW2PJB5P5XASXZTK3QXIE2D462R5DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUHA3DOMZWHA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
   > and Android
   > <https://github.com/notifications/mobile/android/AW2PJBZPO4Y7R2U4CA3NSX3462R5DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUHA3DOMZWHA2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
   > Download it today!
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] jax_fingerprint: Emit type-default for custom log fields with no transaction [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #13243:
URL: https://github.com/apache/trafficserver/pull/13243#issuecomment-4714225851

   Cherry-picked to 10.2.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] jax_fingerprint: Emit type-default for custom log fields with no transaction [trafficserver]

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13243:
URL: https://github.com/apache/trafficserver/pull/13243#issuecomment-4648673684

   @amirnoshian If you could open an issue that would help us track it. This is not the right thread for your comment. Please ask if you would like help opening an issue or have questions about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] jax_fingerprint: Emit type-default for custom log fields with no transaction [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13243:
URL: https://github.com/apache/trafficserver/pull/13243#issuecomment-4650189106

   [approve ci osx freebsd]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] jax_fingerprint: Emit type-default for custom log fields with no transaction [trafficserver]

Posted by "amirnoshian (via GitHub)" <gi...@apache.org>.
amirnoshian commented on PR #13243:
URL: https://github.com/apache/trafficserver/pull/13243#issuecomment-4642954713

   I’m trying to build the project using version 8, but I’m encountering some issues.
   
   When building traffic_opc with the Dockerfile, there seems to be a problem with pdgp:13. It looks like this dependency or image might need to be changed.
   
   Additionally, I’m also having issues with the Traffic Ops Dockerfile during the build process.
   
   Does anyone have any suggestions on how to resolve these problems?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org