You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/12 02:08:39 UTC
[GitHub] [incubator-nuttx] jerry-tang-realsil opened a new pull request #3696: Realtek AmebaZ2 rtl8720c init
jerry-tang-realsil opened a new pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696
## Summary
Add Realtek AmebaZ2 rtl8720c by realsil/jerry_tang
## Impact
add a new chip
## Testing
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerry-tang-realsil commented on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
jerry-tang-realsil commented on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853488223
Dear Alan
Thanks for your advice. It’s OK to close my PR.
BRs
jerry
发件人: Alan Carvalho de Assis ***@***.***
发送时间: 2021年6月3日 4:36
收件人: apache/incubator-nuttx ***@***.***>
抄送: 唐帅帅 ***@***.***>; Mention ***@***.***>
主题: Re: [apache/incubator-nuttx] Realtek AmebaZ2 rtl8720c init (#3696)
@xiaoxiang781216<https://github.com/xiaoxiang781216> I'm going to close this PR, are you fine with it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853365341>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP2FFPFKGDQVWH6A5FTOSD3TQ2I2PANCNFSM44XTGXXQ>.
------Please consider the environment before printing this e-mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853365341
@xiaoxiang781216 I'm going to close this PR, are you fine with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis closed pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
acassis closed pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis closed pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
acassis closed pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerry-tang-realsil commented on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
jerry-tang-realsil commented on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853488223
Dear Alan
Thanks for your advice. It’s OK to close my PR.
BRs
jerry
发件人: Alan Carvalho de Assis ***@***.***
发送时间: 2021年6月3日 4:36
收件人: apache/incubator-nuttx ***@***.***>
抄送: 唐帅帅 ***@***.***>; Mention ***@***.***>
主题: Re: [apache/incubator-nuttx] Realtek AmebaZ2 rtl8720c init (#3696)
@xiaoxiang781216<https://github.com/xiaoxiang781216> I'm going to close this PR, are you fine with it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853365341>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP2FFPFKGDQVWH6A5FTOSD3TQ2I2PANCNFSM44XTGXXQ>.
------Please consider the environment before printing this e-mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#discussion_r630848065
##########
File path: boards/arm/rtl8720c/rtl8720c/src/Makefile
##########
@@ -0,0 +1,47 @@
+############################################################################
+# boards/arm/rtl8720c/rtl8720c/src/Makefile
+#
+# Copyright (C) 2012 Gregory Nutt. All rights reserved.
+# Author: Gregory Nutt <gn...@nuttx.org>
Review comment:
Please change all copyright to apache
##########
File path: boards/arm/rtl8720c/rtl8720c/src/etc/init.d/rcS
##########
@@ -0,0 +1,81 @@
+/****************************************************************************
+ * boards/arm/ameba/amebaZ/src/etc/init.d/rcS
+ *
+ * Copyright (C) 2019 Xiaomi Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
Review comment:
Please change all copyright to apache
##########
File path: boards/arm/rtl8720c/rtl8720c/src/amebaz_bringup.c
##########
@@ -0,0 +1,70 @@
+/****************************************************************************
+ * boards/arm/ameba/amebaZ/src/amebaz_bringup.c
+ *
+ * Copyright (C) 2019 Xiaomi Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
Review comment:
Please change all copyright to apache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853362945
Please don't include these binary files, there are many:
arch/arm/src/rtl8720c/8710c/misc/bsp/lib/common/GCC/lib_soc_is.a
arch/arm/src/rtl8720c/8710c/misc/bsp/lib/common/GCC/lib_wlan.a
tools/rtl8720c/record.dat
tools/rtl8720c/partition.bin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853362945
Please don't include these binary files, there are many:
arch/arm/src/rtl8720c/8710c/misc/bsp/lib/common/GCC/lib_soc_is.a
arch/arm/src/rtl8720c/8710c/misc/bsp/lib/common/GCC/lib_wlan.a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerry-tang-realsil commented on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
jerry-tang-realsil commented on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-839378358
Add basic files for rtl8720c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerry-tang-realsil removed a comment on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
jerry-tang-realsil removed a comment on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-839378358
Add basic files for rtl8720c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853364941
Please @jerry-tang-realsil if you want to include support to WiFi on NuttX for you chip using a proprietary library you need to do as we did for ESP32/ESP32-C3: download the binary from external site during the build process.
Also I suggest you to break this PR is small pieces: just submit the basic ARCH support, then the board support, then drivers, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3696: Realtek AmebaZ2 rtl8720c init
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3696:
URL: https://github.com/apache/incubator-nuttx/pull/3696#issuecomment-853364941
Please @jerry-tang-realsil if you want to include support to WiFi on NuttX for you chip using a proprietary library you need to do as we did for ESP32/ESP32-C3: download the binary from external site during the build process.
Also I suggest you to break this PR is small pieces: just submit the basic ARCH support, then then board support, then drivers, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org